Skip to content

refactor(skills): reorganize skills under .agents - #2403

Merged
rkaraivanov merged 15 commits into
masterfrom
repo-skills-relocation
Sep 24, 2026
Merged

rkaraivanov merged 15 commits into
masterfrom
repo-skills-relocation

Conversation

@kdinev

@kdinev kdinev commented Sep 24, 2026

Copy link
Copy Markdown
Member

Description

Provide a clear and concise summary of the changes in this PR and the motivation behind them

Type of Change

  • Documentation update
  • Refactoring (code improvements without functional changes)

Related Issues

Closes #

Testing

Checklist

  • I have updated documentation if needed

@kdinev
kdinev requested a review from rkaraivanov September 24, 2026 09:28
@kdinev
kdinev changed the base branch from skills-license to master September 24, 2026 09:28
@kdinev
kdinev requested a lite review from Copilot September 24, 2026 09:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Resolve the two moderate issues before approval.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Medium severity · 1 Low severity

Open (2)
What changed in this PR

This PR reorganizes contributor skills under .agents, updates documentation links, and adds ACS configuration and context.

Changes:

  • Updates skill and guideline references.
  • Adds skill-authoring guidance, manifest, permissions, and project context.
  • Modifies the pre-commit hook.
File Summary
skills/​README.md Updated skill references.
.husky/​pre-commit Comments out lint-staged; moderate issue (4 votes).
.github/​copilot-instructions.md Updated skills location guidance.
.github/​CODING_GUIDELINES.md Updated skills documentation link.
.agents/​skills/​update-component-styles/​SKILL.md Relocated contributor workflow.
.agents/​skills/​skill-authoring/​SKILL.md Added authoring guidance; missing required license field, moderate issue (4 votes).
.agents/​skills/​review-component-pr/​SKILL.md Relocated contributor workflow.
.agents/​skills/​README.md Documented skills; contains user-invokable typo, nit (3 votes).
.agents/​skills/​create-new-component/​SKILL.md Relocated contributor workflow.
.agents/​skills/​add-component-property/​SKILL.md Relocated contributor workflow.
.agents/​permissions/​policy.yaml Added agent permission policy.
.agents/​main.yaml Added ACS manifest; misleading skills-layer comment, nit (2 votes).
.agents/​context/​project.md Added project context and workflow guidance.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .agents/skills/skill-authoring/SKILL.md Outdated
Comment thread .agents/main.yaml Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Address the critical nested .envrc permission gap and the skill metadata and consistency issues.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity

Open (1)
Resolved since last review (2)
Previously missed (1)

In code that hasn't changed since last review

Medium severity Existing skills do not follow the new frontmatter rules

.agents/​skills/​README.md:36

These new rules are immediately inconsistent with the existing contributor skills: create-new-component, add-component-property, update-component-styles, and review-component-pr still have only name and description frontmatter, with no license or WHEN TO USE:/WHEN NOT TO USE: markers. Either migrate those skills in this PR or state that the rules apply only to newly created skills.

This issue also appears on line 35 of the same file.

Comment thread .agents/permissions/policy.yaml Outdated
kdinev and others added 2 commits September 24, 2026 14:09
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

The authoring skill omits its required license field, and the README guidance has consistency issues.

Review effort: Lite
Findings: None

Resolved since last review (1)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

A critical permissions issue and several documentation inconsistencies remain unresolved.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity · 1 Low severity

Open (2)

Comment thread .agents/permissions/policy.yaml Outdated
Comment thread skills/README.md Outdated
Add new patterns to ignore PEM, KEY, and PFX files.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: kdinev <1472513+kdinev@users.noreply.github.com>
@kdinev
kdinev requested a lite review from Copilot September 24, 2026 11:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Correct the documented user-invocable spelling and make the skill description comply with the new authoring rule.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 Low severity

Open (1)
Resolved since last review (2)

Comment thread .agents/skills/skill-authoring/SKILL.md Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The permissions policy leaves protected files writable, and the skill documentation has consistency issues.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 High severity

Open (1)
Resolved since last review (1)
Previously missed (1)

In code that hasn't changed since last review

Low severity Incorrect user-invokable frontmatter key spelling

.agents/​skills/​README.md:35

This documents the frontmatter key as user-invokable, but the skill format and the new skill-authoring skill use user-invocable. Following this instruction would silently produce an unrecognized key, so change it to the valid spelling.

Comment thread .agents/permissions/policy.yaml Outdated
Copilot stopped work on behalf of kdinev due to an error September 24, 2026 12:07
@rkaraivanov
rkaraivanov merged commit a249683 into master Sep 24, 2026
7 checks passed
@rkaraivanov
rkaraivanov deleted the repo-skills-relocation branch September 24, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants