fix: report native status and privilege errors accurately - #205
Open
MataM15 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Report native memory-operation failures using the correct Windows error semantics. This independent contribution is based on upstream
main; candidate commit:16f2026.Related Issue
No exact issue identified. The two GCHandle initialization fixes already proposed in #195 and #203 are intentionally excluded to avoid duplicating that work.
Changes
RtlNtStatusToDosErrorinstead of reading unrelated last-error state.AdjustTokenPrivilegescall andERROR_SUCCESS; capture the error immediately.Checklist
Additional Notes
Standalone hosted Windows validation: Release build with 0 warnings and 0 errors; all 7 selected NUnit tests passed on this exact candidate. These are focused tests, not a claim that the entire suite or live cleanup scenarios were exercised.
The fork-only validation workflow, benchmark, packaging tools, and unrelated fork changes are not included. Scope: 5 files, 133 changed lines.