Repository navigation
fix(build): keep runtime installation compatible with PDM 2.28 - #162
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fresh runtime image builds fail before application installation because unearth 0.19.0 switched its client to httpx2 while the fixed PDM 2.28.0 still initializes httpx.Client. Pin the builder-only unearth dependency to the compatible 0.18.3 release. Product dependencies and the PDM version stay unchanged.
This unblocks release #161. The release contract requires this build repair to be reviewed separately from version preparation.
Validation: an isolated PDM 2.28.0 environment reproduces the TypeError with unearth 0.19.0; changing only unearth to 0.18.3 makes the same client perform a live PyPI request successfully (HTTP 200). The required repository, standalone CLI, preview-database, and runtime E2E checks passed on aa5d48d, including the actual Docker build. Main artifact publication and deployment passed after merge b84d57b. No implementation-mirroring test is added for a dependency pin.
Risk: a future PDM upgrade must review this compatibility pin. Normal main artifact publication and deployment run after merging; project versions are unchanged, so this PR does not publish a new CLI or Extension version.