Repository navigation
fix(webapp): give a blank timed lyric line a visible box - #291
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
Le titre est court, précis et décrit le changement principal : rendre visible la boîte d’une ligne de paroles temporisée vide. |
| Description check | |
La description explique clairement le problème, les changements, les tests exécutés et la validation par inversion. Elle n’utilise pas exactement les sections du modèle et ne confirme pas explicitemen… |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 2 files. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Description check
-
Explanation
La description explique clairement le problème, les changements, les tests exécutés et la validation par inversion. Elle n’utilise pas exactement les sections du modèle et ne confirme pas explicitement le test manuel ni le DCO, mais elle reste suffisamment complète et pertinente.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Comment @coderabbitai help to get the list of available commands.
github-actions
Bot
added
scope: web
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
3a8bb36 to
99de200
Compare
A line with no words rendered a plain space, which is collapsible, so its
line box had no height: in the lyrics view a blank timed line became a
button zero pixels tall that the keyboard still reached and nobody could
see, focus ring included. Both views now fall back to a non-breaking
space, which holds one line of height, so the pause keeps its place in the
sheet and its button a box. axe trims it as whitespace, so the name
"Jump to {when}" still contains everything on screen.
The e2e test that counted the blank line's button, because it could not
be visible, now asks for it to be visible.
Signed-off-by: InstaZDLL <github.105mh@8shield.net>
99de200 to
c04c6f8
Compare
1 participant
Stacked on #290: it targets that branch and will retarget to main once #290 merges.
Why
A timed lyric line with no words (an instrumental break) rendered
{line.value || " "}, a plain space. A plain space is collapsible, so the line box had no height: in the lyrics view the line became abutton.linkzero pixels tall. The keyboard still reached it and announced it as "Jump to {when}", but nothing was drawn, focus ring included. This predates #290; the coverage a review asked for there is what brought it to light.What
playing-page.tsx: the three fallbacks (the strip's<li>, the timed button, the untimed<li>) now useBLANK_LINE, a non-breaking space (" "). It holds one line of height, so the pause keeps its place in the sheet and its button has a box. axe'ssanitizetrims it like any whitespace, solabel-content-name-mismatchstill finds nothing visible missing from "Jump to {when}".studio-nocturne.spec.ts: the blank line's button was checked withtoHaveCount(1)because it could not be visible; it is nowtoBeVisible().Verification
bun run lint,bun run test(172 passed),bun run build.bunx playwright test: 138 passed, 10 skipped (the spec's existingtest.skip(calls), desktop and mobile, axe clean.BLANK_LINEset back to a plain space and the bundle rebuilt, the test fails onJump to 0:20withunexpected value "hidden".Summary by CodeRabbit