Apply RPATH logic for OSX - #351
Merged
Merged
Conversation
ndgrigorian
requested review from
antonwolfy,
jharlow-intel and
xaleryb
as code owners
July 31, 2026 15:28
identical logic was used in mkl-service
ndgrigorian
force-pushed
the
fix-rpath-osx
branch
from
July 31, 2026 15:30
4d59b50 to
70c7a02
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores RPATH handling in the Meson build to support macOS (as used by conda-forge), aligning runtime library discovery behavior with mkl-service.
Changes:
- Extend RPATH setup from Linux-only to all non-Windows platforms.
- Use
@loader_pathon macOS and$ORIGINelsewhere to construct relative RPATH entries.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
meson.build:39
- On macOS,
-rpathdoes not accept a colon-separated list the way GNU ld does; passing@loader_path/../..:@loader_path/../../..will be treated as a single (invalid) path. Buildrpath_link_argsas multiple-Wl,-rpath,<path>entries instead of concatenating with:.
rpath = origin / '../..' + ':' + origin / '../../..'
rpath_link_args = ['-Wl,-rpath,' + rpath]
vlad-perevezentsev
approved these changes
Jul 31, 2026
vlad-perevezentsev
left a comment
vlad-perevezentsev
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
Thank you @ndgrigorian !
ndgrigorian
added a commit
that referenced
this pull request
Jul 31, 2026
ndgrigorian
added a commit
that referenced
this pull request
Jul 31, 2026
ndgrigorian
added a commit
that referenced
this pull request
Jul 31, 2026
ndgrigorian
added a commit
that referenced
this pull request
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an oversight when mkl_fft was updated to use meson-python, namely, that mkl_fft is built for OSX on conda-forge. Logic for the RPATH was removed.
This PR reverts that change, aligning to mkl-service