[Timongcraft]

Overview

based on: EngineHub/WorldEdit#3009
follow up of: #3367

I'm not sure if I should mark the sendFakeOp for removal for v3 or how that should be handled.

Submitter Checklist

• Make sure you are opening from a topic branch (/feature/fix/docs/ branch (right side)) and not your main branch.
• Ensure that the pull request title represents the desired changelog entry.
  - [] New public fields and methods are annotated with @since TODO.
• I read and followed the contribution guidelines.

[MattBDev]

I'm not sure if I should mark the sendFakeOp for removal for v3 or how that should be handled.

Given that it is an upstream method that we've added to several other classes, I'm okay with leaving it just as @Deprecated.

I'm a little hesitant of doing even more API breakages on v2 but since upstream as made so many on 7.4 lately, it may just be something we have to do in moderation right now until we can get v3 to where we want it.
For this reason, I am approving this PR.

[Timongcraft]

Given that it is an upstream method that we've added to several other classes, I'm okay with leaving it just as @Deprecated.

No it is not an upstream method, I added the sendFakeOP in the old PR and upstream didn't like to expose that publically, as they said it caused problems in modded environments. So this method only exists since august.

[MattBDev]

Given that it is an upstream method that we've added to several other classes, I'm okay with leaving it just as @Deprecated.

No it is not an upstream method, I added the sendFakeOP in the old PR and upstream didn't like to expose that publically, as they said it caused problems in modded environments. So this method only exists since august.

I must have misread something somewhere.