fix: prevent NullPointerException in world setup when getWorld returns null by bastigfz · Pull Request #4901 · IntellectualSites/PlotSquared

bastigfz · 2026-07-15T11:54:21Z

Description

Fixes a NullPointerException that occurs during /plot setup when BukkitUtil.getSpawn() is called for a world that has not yet been registered with Bukkit.

Root Cause

BukkitUtil.getSpawn() called getWorld(world).getSpawnLocation() without a null check. During the plot setup process, the world may not yet be available via Bukkit.getWorld(), causing:

java.lang.NullPointerException: Cannot invoke "org.bukkit.World.getSpawnLocation()"
because the return value of "com.plotsquared.bukkit.util.BukkitUtil.getWorld(String)" is null
  at BukkitUtil.getSpawn(BukkitUtil.java:318)
  at CommonSetupSteps.java:231

Fix

Added a null check in BukkitUtil.getSpawn(), returning a safe fallback spawn location at (0, 64, 0) when the world is not yet available. This is consistent with the existing null-safe pattern already used in setSpawn().

Pull request overview

Fixes /plot setup failing with an exception when BukkitUtil.getSpawn() is invoked for a world that is not yet registered in Bukkit.

Changes:

Adds a null-check around getWorld(world) in BukkitUtil.getSpawn().
Introduces a fallback spawn location when the Bukkit world is unavailable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

-        final org.bukkit.Location temp = getWorld(world).getSpawnLocation();
+        final World bukkitWorld = getWorld(world);
+        if (bukkitWorld == null) {
+            return Location.at(world, 0, 64, 0);


Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

+        final World bukkitWorld = getWorld(world);
+        if (bukkitWorld == null) {
+            return UncheckedWorldLocation.at(world, 0, 64, 0);
+        }
+        final org.bukkit.Location temp = bukkitWorld.getSpawnLocation();


SirYwell · 2026-07-15T12:06:18Z

During the plot setup process, the world may not yet be available via Bukkit.getWorld()

Why is that?

…s null BukkitUtil.getSpawn() assumed getWorld() would never return null, but during the /plot setup process the world may not yet be registered with Bukkit when getSpawn() is called, causing a NullPointerException. This adds a null check in getSpawn(), returning a safe fallback spawn location at (0, 64, 0) when the world is not yet available, consistent with the existing null-safe pattern used in setSpawn(). Uses UncheckedWorldLocation for the fallback to avoid a secondary exception from Location.at() which resolves the platform world internally and throws if the world is not registered. Also adds a null check in BukkitPlayer.teleport() to prevent a NullPointerException when constructing the Bukkit Location from a world that is not yet registered. Fixes the following error during /plot setup: java.lang.NullPointerException: Cannot invoke "org.bukkit.World.getSpawnLocation()" because the return value of "com.plotsquared.bukkit.util.BukkitUtil.getWorld(String)" is null

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

MattBDev · 2026-07-15T12:14:48Z

I've never encountered this. I'm going to look into this before approving.

bastigfz · 2026-07-15T12:15:20Z

Why is that?

@SirYwell

The issue occurs because BukkitSetupUtils.setupWorld() calls worldManager().handleWorldCreation(...) which may create the world asynchronously (e.g. via Multiverse or Paper world creation). After that call, Bukkit.getWorld(world) can still be null, but setupWorld() returns the world name anyway:

Objects.requireNonNull(PlotSquared.platform()).worldManager()
        .handleWorldCreation(builder.worldName(), builder.generatorName());

if (Bukkit.getWorld(world) != null) {
    return world;
}

return builder.worldName();

Back in CHOOSE_WORLD_NAME, getSpawn(world) is called immediately after setupWorld() returns, and at that point the world may not yet be registered with Bukkit, causing the NPE.

SirYwell · 2026-07-15T12:36:28Z

The issue occurs because BukkitSetupUtils.setupWorld() calls worldManager().handleWorldCreation(...) which may create the world asynchronously (e.g. via Multiverse or Paper world creation).

No, world creation is not asynchronous. Maybe your fork is at fault.

bastigfz · 2026-07-15T12:40:46Z

No, world creation is not asynchronous. Maybe your fork is at fault.

You are right, Bukkit.createWorld() is synchronous. I was wrong about async world creation.

Looking at the stack trace from the reporter again:

[16:52:05] NPE at BukkitUtil.getSpawn()
[16:52:05] Creating world plotworld...
[16:52:06] World plotworld created!

The NPE happens before the world is even created. This means setupWorld() returned the world name without handleWorldCreation() having been called, or the world creation failed silently.

I cannot fully explain the root cause from the code alone – it could be a Leaf-specific behavior, a version mismatch in 7.5.13-Premium, or something else. However, the defensive null-checks in getSpawn() and BukkitPlayer.teleport() are still valid: they prevent the crash regardless of why the world is not registered, and they follow the same null-safe pattern already used in setSpawn().

SirYwell · 2026-07-26T09:47:31Z

No, world creation is not asynchronous. Maybe your fork is at fault.

You are right, Bukkit.createWorld() is synchronous. I was wrong about async world creation.

Looking at the stack trace from the reporter again:
[16:52:05] NPE at BukkitUtil.getSpawn()
[16:52:05] Creating world plotworld...
[16:52:06] World plotworld created!
The NPE happens before the world is even created. This means setupWorld() returned the world name without handleWorldCreation() having been called, or the world creation failed silently.

I cannot fully explain the root cause from the code alone – it could be a Leaf-specific behavior, a version mismatch in 7.5.13-Premium, or something else. However, the defensive null-checks in getSpawn() and BukkitPlayer.teleport() are still valid: they prevent the crash regardless of why the world is not registered, and they follow the same null-safe pattern already used in setSpawn().

This really sounds like a problem with the server software you are using.

NonSwag · 2026-07-26T09:53:54Z

#createWorld will only ever return null if another world with the exact same UUID already exists, everything else throws an exception.
If the world did not exist before (which is generally the case for the setup command) #createWorldwill never return null

Copilot AI review requested due to automatic review settings July 15, 2026 11:54

bastigfz requested a review from a team as a code owner July 15, 2026 11:54

Copilot started reviewing on behalf of bastigfz July 15, 2026 11:54 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Comment thread Bukkit/src/main/java/com/plotsquared/bukkit/util/BukkitUtil.java Outdated

final org.bukkit.Location temp = getWorld(world).getSpawnLocation();

final World bukkitWorld = getWorld(world);

if (bukkitWorld == null) {

return Location.at(world, 0, 64, 0);

Copilot AI review requested due to automatic review settings July 15, 2026 11:59

bastigfz force-pushed the fix/setup-world-npe-v2 branch 2 times, most recently from 1043eb6 to 222222f Compare July 15, 2026 11:59

Copilot started reviewing on behalf of bastigfz July 15, 2026 11:59 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings July 15, 2026 12:07

bastigfz force-pushed the fix/setup-world-npe-v2 branch from 222222f to 79f9d25 Compare July 15, 2026 12:07

Copilot started reviewing on behalf of bastigfz July 15, 2026 12:08 View session

Copilot AI reviewed Jul 15, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: prevent NullPointerException in world setup when getWorld returns null - #4901

fix: prevent NullPointerException in world setup when getWorld returns null#4901
bastigfz wants to merge 1 commit into
IntellectualSites:mainfrom
bastigfz:fix/setup-world-npe-v2

bastigfz commented Jul 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

SirYwell commented Jul 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

MattBDev commented Jul 15, 2026

Uh oh!

bastigfz commented Jul 15, 2026 •

edited

Loading

Uh oh!

SirYwell commented Jul 15, 2026

Uh oh!

bastigfz commented Jul 15, 2026

Uh oh!

SirYwell commented Jul 26, 2026

Uh oh!

NonSwag commented Jul 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Uh oh!

Conversation

bastigfz commented Jul 15, 2026

Description

Root Cause

Fix

Related

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

SirYwell commented Jul 15, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

MattBDev commented Jul 15, 2026

Uh oh!

bastigfz commented Jul 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SirYwell commented Jul 15, 2026

Uh oh!

bastigfz commented Jul 15, 2026

Uh oh!

SirYwell commented Jul 26, 2026

Uh oh!

NonSwag commented Jul 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

bastigfz commented Jul 15, 2026 •

edited

Loading