Repository navigation
Add Robin PR review workflow - #1
VineeTagarwaL-code wants to merge 2 commits into
Conversation
🏹 Robin✅ Review done. I flagged 1 thing worth a look. Push fixes whenever you like, then comment Robin v2.8.0 · yoeven/robin@main (e75fa54) · diff-only review (model has no tool support) |
There was a problem hiding this comment.
🏹 Robin
Heads up: this is a point-in-time review. Push fixes freely, then comment
/robinwhenever you want another pass.
Summary
The workflow keeps integration concise, declares permissions explicitly, and passes only named secrets rather than inheriting all repository secrets. The main concern is that a third-party workflow receives credentials and write permissions while being referenced through a mutable branch.
Robin — the Robin Hood of code review. Free for every PR.
|
|
||
| jobs: | ||
| review: | ||
| uses: yoeven/robin/.github/workflows/review.yml@main |
There was a problem hiding this comment.
Robin —
The reusable workflow is loaded from the mutable main branch. Upstream changes can therefore execute without a reviewed change in this repository, with access to LLM_API_KEY and a token granted pull-request write permission. A compromised upstream workflow could exfiltrate the credential or misuse that permission.
Recommendation: Pin the reusable workflow to a reviewed full commit SHA and update that pin through reviewed dependency updates.
🏹 Robin✅ Review done. I flagged 1 thing worth a look. Push fixes whenever you like, then comment Robin v2.8.0 · yoeven/robin@main (e75fa54) · diff-only review (model has no tool support) |
There was a problem hiding this comment.
🏹 Robin
Heads up: this is a point-in-time review. Push fixes freely, then comment
/robinwhenever you want another pass.
Summary
The workflow keeps repository access mostly read-only and explicitly passes only the intended secrets to the reusable review workflow. However, it executes third-party workflow code from a mutable branch while providing an API key and pull-request write permission.
Robin — the Robin Hood of code review. Free for every PR.
|
|
||
| jobs: | ||
| review: | ||
| uses: yoeven/robin/.github/workflows/review.yml@main |
There was a problem hiding this comment.
Robin —
The reusable workflow is referenced with @main, so upstream changes execute without a corresponding reviewed change in this repository. That code receives LLM_API_KEY and a token with pull-request write permission, making an upstream compromise capable of exposing the key or modifying pull requests.
Recommendation: Pin the reusable workflow to a reviewed full commit SHA and update that pin through reviewed dependency-update pull requests.
|
Closing: Robin is for internal repos only. |
Adds the Robin review workflow, the same file used in interfaze, interfaze-landing and defaultmodel-landing. It needs the LLM_API_KEY, LLM_BASE_URL and LLM_MODEL repo secrets to run.