fix(publish): keep the failing test of a pytest run in a draft PR's Last failure (AGT-4672) - #812
Merged
Merged
Conversation
…ast failure (AGT-4672) summarizeFailure kept the first 500 characters. For a pytest failure those are progress dots, so drafts #796 and #798 said nothing about what failed; the failing test ids and totals are at the end. Drop progress runs and percentage marks first, then keep the head and the tail of what is left.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
summarizeFailurekept the first 500 characters of the failure detail. For a pytest failure those are progress dots (....ss.... [ 12%]); the failing test ids and the totals are at the end. A reader of the draft PR could not tell what failed.Evidence
Last failure: [pytest:apps/pipelines] ......... [ 10%] ....and nothing else (518 chars, all progress).Change
publishOnPark.ts: drop progress runs (8+ characters of. s x X F E) and[ NN%]marks before flattening; when the rest is still over 500 characters keep the first 150 and the last 350 with…between, so the final failure lines survive.summarizeFailureis exported for the test.publishOnPark.test.ts: a long pytest run keeps theFAILED ...id and the totals; a long detail without progress rows keeps both ends; a short or empty detail is unchanged. Restoring the old cut fails two of the three.Verification
vitestpublishOnPark and runnerFailureDetail: 2 files, 72 tests pass.