Skip to content

fix(publish): keep the failing test of a pytest run in a draft PR's Last failure (AGT-4672) - #812

Merged
unohee merged 1 commit into
mainfrom
fix/agt-4672-failure-summary-tail
Oct 3, 2026
Merged

unohee merged 1 commit into
mainfrom
fix/agt-4672-failure-summary-tail

Conversation

@unohee

@unohee unohee commented Oct 3, 2026

Copy link
Copy Markdown
Collaborator

TL;DR

summarizeFailure kept the first 500 characters of the failure detail. For a pytest failure those are progress dots (....ss.... [ 12%]); the failing test ids and the totals are at the end. A reader of the draft PR could not tell what failed.

Evidence

Change

  • publishOnPark.ts: drop progress runs (8+ characters of . s x X F E) and [ NN%] marks before flattening; when the rest is still over 500 characters keep the first 150 and the last 350 with … between, so the final failure lines survive. summarizeFailure is exported for the test.
  • publishOnPark.test.ts: a long pytest run keeps the FAILED ... id and the totals; a long detail without progress rows keeps both ends; a short or empty detail is unchanged. Restoring the old cut fails two of the three.

Verification

  • vitest publishOnPark and runnerFailureDetail: 2 files, 72 tests pass.
  • Live check after deploy: the next draft for a pytest failure names the failing test or totals.

…ast failure (AGT-4672)

summarizeFailure kept the first 500 characters. For a pytest failure those are
progress dots, so drafts #796 and #798 said nothing about what failed; the
failing test ids and totals are at the end. Drop progress runs and percentage
marks first, then keep the head and the tail of what is left.
@unohee
unohee merged commit 83d062d into main Oct 3, 2026
7 checks passed
@unohee
unohee deleted the fix/agt-4672-failure-summary-tail branch October 3, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant