Repository navigation
chore(deps): update dependency gitpython to v3.1.62 [security] - #31
Open
dependency-automation-app[bot] wants to merge 1 commit into
Open
dependency-automation-app[bot] wants to merge 1 commit into
dependency-automation-app[bot] wants to merge 1 commit into
Conversation
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.1.60->3.1.62GitHub Vulnerability Alerts
GHSA-59cr-6r3x-644w
Affected:
GitPython3.1.61 (latest release) andmain—git/objects/submodule/base.py.git diff 3.1.61 origin/main -- git/objects/submodule/is empty, so both are identical here.The gap
The fix for
GHSA-hmq2-w58f-27jcaddedSubmodule._validated_name()and wired it intoupdate()and five siblings, closing the.gitmodulesname →.git/modules/<name>traversal. The other attacker-controlled.gitmodulesfield,path, is read raw:and GitPython's own containment guard is applied in only two of the places that consume it:
update()validates only the name and then uses the path-derived absolute location directly:So
path = ../../../tmp/escapedin an attacker-authored.gitmodulesselects the directory that gets created and, on the clone path, populated from the submodule URL. The same absolute location is whatforce_removehands toshutil.rmtree.The asymmetry is the argument: this is not a missing concept — the project wrote
_to_relative_path()precisely for this, andadd()/move()use it.update()does not.Honest limits (please read before rating)
Repo.clone_from(...)→repo.submodules→sm.update(init=True)re-derivespathfrom a canonical tree lookup, and real git refuses to check out a tree containing a..component, so an evil.gitmodulesnever lands in the working tree in the first place. A reachable trigger therefore requires the victim's code to name a non-HEAD commit (a historical-commit API such assubmodule_update(previous_commit=...)).update(), and the unguardedabspath→os.makedirs()flow at 3.1.61 ==main.Suggested fix
Apply the guard the project already has, wherever the path is consumed:
Better still, validate at the boundary: reject a
.gitmodulesentry whosepathis absolute or contains a..component when the section is first read in_set_cache_()/iter_items(), so no consumer can be added later without the check. A regression test withpath = ../escapedalongside the existingnametest would pin both fields.Prior art checked
GHSA-hmq2-w58f-27jc(this is a residual of its fix, in the sibling field, not a re-report) plus the repository's 30 published advisories — none mentions thepathfield or_to_relative_path. Searched issues and PRs for_to_relative_path,gitmodules pathandsubmodule traversal: no report of this.Credit
kta1kri.
Appendix —
EVIDENCE_gitpython_path_unguarded_20260901.txt(inlined; advisories accept no attachments)Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.