Skip to content

Allow use EntityIds for spawn patterns - #56

Merged
IvanCraft623 merged 5 commits into
IvanCraft623:mainfrom
kostamax27:fix/pattern-factory
Jul 28, 2026
Merged

Allow use EntityIds for spawn patterns#56
IvanCraft623 merged 5 commits into
IvanCraft623:mainfrom
kostamax27:fix/pattern-factory

Conversation

@kostamax27

Copy link
Copy Markdown
Contributor

No description provided.

@IvanCraft623

Copy link
Copy Markdown
Owner

I don't like this EntityIds is for protocol specific scope, and it's prone to change as mojang wants. In fact id is just for an easy idenfication to unregister them if a plugin dev wants to...

@kostamax27

Copy link
Copy Markdown
Contributor Author

I don't like this EntityIds is for protocol specific scope, and it's prone to change as mojang wants. In fact id is just for an easy idenfication to unregister them if a plugin dev wants to...

It’s just that it could make register/unregister a bit easier for developers.

@IvanCraft623

IvanCraft623 commented Jul 27, 2026

Copy link
Copy Markdown
Owner

It’s just that it could make register/unregister a bit easier for developers.

In that case an utility class like BlockPatternIds with the constants will be a better aproach

@kostamax27

Copy link
Copy Markdown
Contributor Author

It’s just that it could make register/unregister a bit easier for developers.

In that case an utility class like BlockPatternIds with the constants will be a better aproach

what about SpawnPatternIds?

@IvanCraft623

Copy link
Copy Markdown
Owner

what about SpawnPatternIds?

The current api it's not atached to mob spawns it could actually do whatever. So a more general name suits better, we can register the ids with something like spawn_iron_golem.

kostamax27 and others added 4 commits July 27, 2026 22:43
Makes pattern IDs more descriptive and self-explanatory when used externally, e.g. BlockPatternIds::SPAWN_WITHER clearly conveys the pattern's purpose.
@IvanCraft623

Copy link
Copy Markdown
Owner

Did some ajustments, thanks for your contribution!

@IvanCraft623
IvanCraft623 merged commit d513b0a into IvanCraft623:main Jul 28, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants