Conversation
Contributor
|
Please resolve conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding excluded columns to a new or parsed wildcard currently produces SQL such as
SELECT * null( hidden ) FROM t. UseEXCEPTwhen no keyword was specified, preserving explicitEXCLUDEand existing keyword casing.The regressions cover programmatic
*, parsed*andt.*, including SQL rendering, deparsing and roundtrips. All three fail before the fix; empty/null exclusion lists and explicit keywords remain covered.Validation on JDK17:
mvn spotless:apply verifyand./gradlew checkpassed, including the full test suites and static checks../gradlew jmhcompleted the standard parser benchmarks.