test: improve test params#56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this PR necessary, what does it do?
This pull request updates the test assertions in
tests/test_editor.pyfor the integer, float, and string search tests. The changes adjust the thresholds for what is considered a passing test, making the tests slightly stricter in terms of the number of found items, but more lenient in terms of correctness.Test assertion threshold adjustments:
found / test_lengthfrom 0.7 to 0.8 in thetest_search_by_int,test_search_by_float, andtest_search_by_stringfunctions to make the tests stricter about finding enough items. [1] [2] [3]correct / totalfrom 0.7 to 0.5 in the same test functions, making the correctness requirement more lenient. [1] [2] [3]Checklist (complete all items):
References:
No references to be shared.
Notes:
No notes to be shared.