Skip to content

test: improve test params#56

Merged
JeanExtreme002 merged 1 commit into
mainfrom
jeanextreme002/improve-test-params
Jun 7, 2026
Merged

test: improve test params#56
JeanExtreme002 merged 1 commit into
mainfrom
jeanextreme002/improve-test-params

Conversation

@JeanExtreme002

@JeanExtreme002 JeanExtreme002 commented Jun 6, 2026

Copy link
Copy Markdown
Owner

Why is this PR necessary, what does it do?
This pull request updates the test assertions in tests/test_editor.py for the integer, float, and string search tests. The changes adjust the thresholds for what is considered a passing test, making the tests slightly stricter in terms of the number of found items, but more lenient in terms of correctness.

Test assertion threshold adjustments:

  • Increased the minimum required ratio for found / test_length from 0.7 to 0.8 in the test_search_by_int, test_search_by_float, and test_search_by_string functions to make the tests stricter about finding enough items. [1] [2] [3]
  • Decreased the minimum required ratio for correct / total from 0.7 to 0.5 in the same test functions, making the correctness requirement more lenient. [1] [2] [3]

Checklist (complete all items):

  • Added tests as necessary.
  • There is no breaking change for existing features.

References:

No references to be shared.

Notes:

No notes to be shared.

@github-actions github-actions Bot added the tests Test changes (tests/) label Jun 6, 2026
@JeanExtreme002 JeanExtreme002 merged commit 5592261 into main Jun 7, 2026
17 of 18 checks passed
@github-actions github-actions Bot deleted the jeanextreme002/improve-test-params branch June 7, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Test changes (tests/)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant