feat: populate MemoryRegion.path on Windows and macOS#64
Closed
JeanExtreme002 wants to merge 4 commits into
Closed
feat: populate MemoryRegion.path on Windows and macOS#64JeanExtreme002 wants to merge 4 commits into
JeanExtreme002 wants to merge 4 commits into
Conversation
- Win32: call GetMappedFileNameW (psapi.dll) for each region - macOS: call proc_regionfilename for each region - Add optional 'path' kwarg to make_region() for backend overrides - Add comprehensive tests for get_memory_regions() in tests/process/
github-actions
Bot
added
app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve the missing
pathfield on memory regions for Windows and macOS. Previously it was always""on both platforms (only Linux populated it from/proc/<pid>/maps).Changes
GetMappedFileNameW(psapi.dll) for each region yielded byVirtualQueryEx, returning the NT device path (e.g.\\Device\\HarddiskVolume3\\Windows\\System32\\ntdll.dll).proc_regionfilenamefor each region yielded bymach_vm_region, returning the full filesystem path.make_region()now accepts an optionalpath=keyword so backends can pass a pre-resolved path without modifying their struct layouts.tests/process/test_memory_regions.pywith comprehensive tests forget_memory_regions()(contract validation + path assertions on all platforms).