Skip to content

tests: accept AbstractDict for compatibility with JSON.jl v1 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lamdor merged 1 commit into from
Jun 11, 2026
Merged

tests: accept AbstractDict for compatibility with JSON.jl v1 #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/utils/ast.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ function after(visitor::ASTVisitor, node)
return pop!(visitor.result_stack) # either a QuerySet or nothing
end

function _visit(visitor::ASTVisitor, ::Type{QuerySet}, node::Dict{String,Any})
function _visit(visitor::ASTVisitor, ::Type{QuerySet}, node::AbstractDict)
if haskey(node, "queries") && length(node["queries"]) > 0
data = node["queries"]
N = length(data)
Expand Down
4 changes: 2 additions & 2 deletions test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,11 +91,11 @@ function test_config_api(openapi_client)
@test length(services) == 1
@test services[1]["name"] == "BundleServiceAPI"

@test haskey(result, "bundles") && isa(result["bundles"], Dict)
@test haskey(result, "bundles") && isa(result["bundles"], AbstractDict)
bundles = result["bundles"]
@test Set(keys(bundles)) == Set(["data", "policies"])

@test haskey(result, "keys") && isa(result["keys"], Dict)
@test haskey(result, "keys") && isa(result["keys"], AbstractDict)
bundle_keys = result["keys"]
@test haskey(bundle_keys, "bundle_key")
@test haskey(bundle_keys["bundle_key"], "algorithm")
Expand Down
2 changes: 1 addition & 1 deletion test/sql_translate.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ function to_sql(queryset::QuerySet)
end
end

function translate(result::Dict{String, Any})
function translate(result::AbstractDict)
if haskey(result, "queries") && length(result["queries"]) > 0
return to_sql(from_data(QuerySet, result["queries"]))
else
Expand Down
Loading