Skip to content

Only revert xy for epsg 4326#60

Merged
meggart merged 6 commits into
masterfrom
fg/xy_again
May 21, 2026
Merged

Only revert xy for epsg 4326#60
meggart merged 6 commits into
masterfrom
fg/xy_again

Conversation

@meggart
Copy link
Copy Markdown
Member

@meggart meggart commented May 21, 2026

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

❌ Patch coverage is 97.22222% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 51.84%. Comparing base (7d8a711) to head (5d98424).

Files with missing lines Patch % Lines
ext/ArchGDALExt/ArchGDALExt.jl 97.22% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #60      +/-   ##
==========================================
+ Coverage   51.44%   51.84%   +0.39%     
==========================================
  Files          12       12              
  Lines         484      488       +4     
==========================================
+ Hits          249      253       +4     
  Misses        235      235              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meggart
Copy link
Copy Markdown
Member Author

meggart commented May 21, 2026

@lazarusA is there a way to test if YAXArray docs are still building and producing correct plots with this PR?

@lazarusA
Copy link
Copy Markdown
Collaborator

lazarusA commented May 21, 2026

just test if this works: https://juliadatacubes.github.io/YAXArrays.jl/stable/UserGuide/read.html#Read-GDAL-GeoTIFF,-GeoJSON

using YAXArrays
using ArchGDAL
using Downloads: download

path = download("https://github.com/yeesian/ArchGDALDatasets/raw/307f8f0e584a39a050c042849004e6a2bd674f99/gdalworkshop/world.tif", "world.tif")
ds = open_dataset(path)

@meggart
Copy link
Copy Markdown
Member Author

meggart commented May 21, 2026

That example is not going through the code path that I changed here. It would rather be this:

using YAXArrays
using ArchGDAL
import ArchGDAL as AG
using Downloads: download

path = download("https://github.com/yeesian/ArchGDALDatasets/raw/307f8f0e584a39a050c042849004e6a2bd674f99/gdalworkshop/world.tif", "world.tif")
ds = YAXArray(AG.readraster(path))

However, this is broken with the old version of this package because they, although they specify EPSG, which should have yx instead of xy. I have reverted the special case so that it works again with your dataset. If you come across cases where the dims are wrong, please ping me and I will try to fix quickly

@meggart meggart merged commit 2e561cb into master May 21, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants