Rebase #146#160
Open
Keno wants to merge 2 commits into
Open
Conversation
…xpr(:method)` in Julia's lowered code (JuliaLang/julia#60099). Add abstraction functions (`ismethod`, `ismethod1`, `ismethod3`, `method_name`, `method_module`, `method_body`) that work with both the old `:method` expression form and the new `define_method` call form. Update signature extraction, `methoddef!`, and code edge analysis to use these abstractions. Handle method table extraction for overlay methods in the `define_method` form. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Co-authored-by: OpenAI Codex <codex@openai.com>
Resolve inline and frame-backed method-table operands before classifying Core.define_method calls, and consistently recognize the new lowered form in code-edge analysis. This preserves external method tables without dropping compatibility with Expr(:method). CI: https://buildkite.com/julialang/julia-master/builds/55542#019cdafc-f96b-438e-a022-9eda4e82ccbe Co-authored-by: OpenAI Codex <codex@openai.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #160 +/- ##
==========================================
- Coverage 76.95% 76.79% -0.16%
==========================================
Files 6 6
Lines 1523 1629 +106
==========================================
+ Hits 1172 1251 +79
- Misses 351 378 +27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.