Fearless taylor version#109
Open
oscardssmith wants to merge 3 commits into
Open
Conversation
Keno
requested changes
Feb 11, 2023
Keno
left a comment
Keno
left a comment
Collaborator
There was a problem hiding this comment.
This is unsound as is, even if you want to make the assumption that taylor-ness is preserved. This just makes everything taylor which is unconditionally unsound.
Member
Author
|
in that case we definitely need test cases that break the assumption that everything is taylor because locally all the tests pass with this PR. (also, can you decipher the error message on CI I'm not able to understand or reproduce it). |
oscardssmith
force-pushed
the
fearless-taylor-version
branch
from
7da6082 to
9b56ede
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 50.50% 50.77% +0.26%
==========================================
Files 27 27
Lines 2651 2572 -79
==========================================
- Hits 1339 1306 -33
+ Misses 1312 1266 -46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we're willing to use the information that derivatives are linear operators, we can remove a lot of complexity from forward mode differentiation (and improve type stability in the process). I know @Keno doesn't believe this is valid to assume, but IMO the simplification enabled provides a pretty strong justification that this is the right approach.