Implement LinearAlgebra's storage-specific mul! methods - #630
Merged
Conversation
maleadt
force-pushed
the
tb/linalg-mul-1.13
branch
2 times, most recently
from
September 3, 2026 13:24
34739ff to
c1d7862
Compare
maleadt
marked this pull request as ready for review
September 3, 2026 14:33
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
==========================================
+ Coverage 81.19% 81.31% +0.11%
==========================================
Files 50 50
Lines 3568 3569 +1
==========================================
+ Hits 2897 2902 +5
+ Misses 671 667 -4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Julia 1.13-rc4 bumped LinearAlgebra to a version that includes JuliaLang/LinearAlgebra.jl#1671, which renamed the storage-level `generic_matvecmul!`/`generic_matmatmul!` entry points into 6- and 7-argument `mul!` methods, with the old names kept only as a fallback behind the generic `mul!` method. For matrix-vector products this breaks oneMKL dispatch: LinearAlgebra's strided BlasFloat `mul!` method is more specific than that fallback, so it wins over our `generic_matvecmul!` overload and calls into CPU BLAS with device pointers. Implement the dense and sparse products as the new `mul!` methods, and keep the legacy names only as forwarding shims for Julia before 1.13 so that they can be dropped together once 1.13 becomes the floor.
maleadt
force-pushed
the
tb/linalg-mul-1.13
branch
from
September 3, 2026 14:47
c1d7862 to
6013fc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julia 1.13-rc4 bumped LinearAlgebra to a version including JuliaLang/LinearAlgebra.jl#1671, which renamed the storage-level
generic_matvecmul!/generic_matmatmul!entry points into 6- and 7-argumentmul!methods. LinearAlgebra's strided BlasFloatmul!is more specific than the fallback that still routes to the old names, so ourgeneric_matvecmul!overload was never reached on 1.13 and matrix-vector products ended up in CPU BLAS.This implements the products as the new
mul!methods and keeps the legacy names only as forwarding shims for Julia < 1.13 (one@staticblock per file, to be dropped when 1.13 becomes the floor). It requires GPUArrays 11.5.14 (JuliaGPU/GPUArrays.jl#775, now registered), whosegeneric_matmatmul_wrapper!hooks route throughmul!on 1.13.