Remove Libz - #447
Merged
Merged
Conversation
nhz2
commented
Aug 24, 2026
| return true | ||
| end | ||
| checked_match(io) && return true | ||
| return detect_compressed(io; formats=["GZIP", "BZIP2", "XZ"]) && !name_matches_compressed_fits(io) |
Member
Author
There was a problem hiding this comment.
This didn't make any sense, all compressed files should not be read by a rdata loader, just because it isn't a compressed fits file.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #447 +/- ##
==========================================
+ Coverage 91.09% 91.18% +0.09%
==========================================
Files 11 11
Lines 719 715 -4
==========================================
- Hits 655 652 -3
+ Misses 64 63 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #316 by dropping gzip support. As noted by @kescobo in #316 this already is completely broken.
I think we could add some kind of package extension to ChunkCodecLibZlib.jl for this, but I'm not sure what the goal is here, usually gzip is just a compression layer on an actual file format, like .tar.gz or .csv.gz, so it seems to me that just dumping the raw decompressed bytes is not that useful.