Skip to content

Clean up Py_buffer definition #1107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuyichao wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Clean up Py_buffer definition #1107

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions src/pybuffer.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
#############################################################################
# mirror of Py_buffer struct in Python Include/object.h

# Stable ABI since 3.11
struct Py_buffer
buf::Ptr{Cvoid}
obj::PyPtr
Expand All @@ -18,20 +19,15 @@ struct Py_buffer
shape::Ptr{Cssize_t}
strides::Ptr{Cssize_t}
suboffsets::Ptr{Cssize_t}

# some opaque padding fields to account for differences between
# Python versions (the structure changed in Python 2.7 and 3.3)
internal0::Ptr{Cvoid}
internal1::Ptr{Cvoid}
internal2::Ptr{Cvoid}
internal::Ptr{Cvoid}
end

mutable struct PyBuffer
buf::Py_buffer
PyBuffer() = begin
b = new(Py_buffer(C_NULL, PyPtr_NULL, 0, 0,
0, 0, C_NULL, C_NULL, C_NULL, C_NULL,
C_NULL, C_NULL, C_NULL))
C_NULL))
finalizer(pydecref, b)
return b
end
Expand Down
Loading