Update breakage: use organization-wide workflow#157
Open
MaxenceGollier wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refactors the Breakage workflow to use the centralized reusable workflows from the JuliaSmoothOptimizers/.github repository, removing local implementations.
Changes:
- Replaces inline Breakage workflow with a call to the reusable workflow from
JuliaSmoothOptimizers/.github. - Adds a new
CommentBreakageworkflow that runs on Breakage workflow completion and delegates to the reusable comment workflow. - Removes the now-unused
.breakage/get_jso_users.jlscript and itsProject.toml.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/Breakage.yml | Replaced custom implementation with a call to the shared reusable workflow. |
| .github/workflows/CommentBreakage.yml | New workflow triggered on Breakage completion to post PR comments via reusable workflow. |
| .breakage/get_jso_users.jl | Removed; functionality moved to the centralized workflow. |
| .breakage/Project.toml | Removed; no longer needed after script deletion. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following JuliaSmoothOptimizers/.github#18.