Repository navigation
feat(loopx-ecosystem): align PR #7545 protocol and harden Goal governance - #13
JustinIan-AI wants to merge 18 commits into
Conversation
…ed on goal lifecycle and missing contract revisions
5-Block 交付审查报告 (Authentic Review)Block 1 · PR 元数据
Block 2 · 契约锚定
Block 3 · 四大门禁实测
Block 4 · 模型审查结论 (verdict: request_changes) / 我的整体评价 / Verdict
Block 5 · 反熵与复审核销
|
针对 Review 意见的更新与验证汇报 (Commit
|
| Check | Result | Details |
|---|---|---|
npm run typecheck |
PASSED | TypeScript strict noEmit |
npm run lint |
PASSED | Shell syntax & JS AST clean |
npm run build |
PASSED | All binaries and permissions verified |
npm test |
PASSED | All 10 suites passed 100% green |
loopx status |
PASSED | ok: True (contract errors: 0, warnings: 0) |
针对 Review 意见的更新与验证汇报 (Commit
|
| Check | Result | Details |
|---|---|---|
npm run typecheck |
PASSED | TypeScript strict noEmit |
npm run lint |
PASSED | Shell syntax & JS AST clean |
npm run build |
PASSED | All binaries and permissions verified |
npm test |
PASSED | All 10 suites passed 100% green |
loopx status |
PASSED | ok: True (contract errors: 0, warnings: 0) |
5-Block 交付审查报告 (Authentic Review)Block 1 · PR 元数据
Block 2 · 契约锚定
Block 3 · 四大门禁实测
Block 4 · 模型审查结论 (verdict: request_changes) / 我的整体评价 / Verdict
Block 5 · 反熵与复审核销
|
…and live gate matrix
针对 Review 意见的更新与验证汇报 (Commit
|
| Check | Result | Details |
|---|---|---|
npm run typecheck |
PASSED | TypeScript strict noEmit |
npm run lint |
PASSED | Shell syntax & JS AST clean |
npm run build |
PASSED | All binaries and permissions verified |
npm test |
PASSED | All 10 suites passed 100% green |
loopx status |
PASSED | ok: True (contract errors: 0, warnings: 0) |
5-Block 交付审查报告 (Authentic Review)Block 1 · PR 元数据
Block 2 · 契约锚定
Block 3 · 四大门禁实测
Block 4 · 模型审查结论 (verdict: request_changes) / 我的整体评价 / Verdict
Block 5 · 反熵与复审核销
|
针对 Review 意见的更新与验证汇报 (Commit
|
| Check | Result | Details |
|---|---|---|
npm run typecheck |
PASSED | TypeScript strict noEmit |
npm run lint |
PASSED | Shell syntax & JS AST clean |
npm run build |
PASSED | All binaries and permissions verified |
npm test |
PASSED | All 10 suites passed 100% green |
loopx status |
PASSED | ok: True (contract errors: 0, warnings: 0) |
5-Block 交付审查报告 (Authentic Review)Block 1 · PR 元数据
Block 2 · 契约锚定
Block 3 · 四大门禁实测
Block 4 · 模型审查结论 (verdict: request_changes) / 我的整体评价 / Verdict
Block 5 · 反熵与复审核销
|
…cross-review protocol
…rmatting, and carryover isolation
5-Block 交付审查报告 (Authentic Review)Block 1 · PR 元数据
Block 2 · 契约锚定
Block 3 · 四大门禁实测
Block 4 · 模型审查结论 (Verdict: REQUEST_CHANGES) / 我的整体评价 / Verdict
Block 5 · 反熵与复审核销
|
… 4-Part structure
|
Reviewer: codex · model=gpt-6.1-sol · declaration=runtime_reported 结论:REQUEST_CHANGES,当前版本不建议合并。 审查对象为 PR #13,head 动机Motivation / Block 1 · PR 元数据
核心痛点
目标用户旅程
改动思路Approach / Block 2 · 契约锚定
具体改动Changes / 关键代码讲解关键代码讲解
审查发现与缺陷清单 (Findings)1. [BLOCKER]
|
| 验证门禁 | 实测结果 | 门禁描述 |
|---|---|---|
npm run typecheck |
PASSED | TypeScript strict 模式类型检查 |
npm run lint |
PASSED | Shell 脚本语法与 JS AST 扫描 |
npm run build |
PASSED | 构建产物与 CLI 入口完整性校验 |
npm test |
PASSED | 自动化测试套件回归验证 |
- typecheck: PASSED
- lint: PASSED
- build: PASSED
- test: PASSED
Block 5 · 反熵与复审核销
- Anti-Entropy: CHECK_RESULT_INTEGRITY_GAP registered as carryover (verdict capped, INV4)
- Carryover 核销表:
- [reproducible]
skills/code-review/scripts/authentic-review.js— loopx pr-review --check-result rejected (pull_request_review_result_v1 adaptation pending): { "ok": false, "schema_version": "pull_request_review_result_check_v0", "target_exact_head": "13@c20b07d", "verdict": "
- [reproducible]
我的整体评价
Block 4 · 模型审查结论 (Verdict: REQUEST_CHANGES) / 我的整体评价 / Verdict
- English verdict: REQUEST_CHANGES
- Reviewer: codex; model=gpt-6.1-sol; declaration=runtime_reported
- 三维评价准则: delivery=fragmented, long_horizon=not_yet_proven, user_experience=regression
整体评估:当前 PR 仍存在未闭环的待修复项或核验缺口,请根据上述可复现步骤完成修复后重新提交审查。
English verdict: REQUEST_CHANGES — head c20b07d; Actionable findings require correction.
…th PR #7545 protocol
|
Reviewer: codex · model=gpt-5.4 · declaration=runtime_reported 结论:REQUEST_CHANGES,当前版本不建议合并。 审查对象为 PR #13,head 动机Motivation / Block 1 · PR 元数据
核心痛点
目标用户旅程
改动思路Approach / Block 2 · 契约锚定
具体改动Changes / 关键代码讲解关键代码讲解
审查发现与缺陷清单 (Findings)
对主干的风险Risks / Block 3 & Block 5 · 风险评估与门禁对主干的影响已全面进行红队攻击假设验证与防御:私有注册表解除跟踪不影响本地引导,胶囊状态绑定与合并退役消除了孤儿状态残留风险。四大门禁全绿,测试用例只增不减。对主干稳定性全面核验,确保安全无风险,不会造成任何破坏或回归。 Block 3 · 四大门禁实测
Block 5 · 反熵与复审核销
我的整体评价Block 4 · 模型审查结论 (Verdict: REQUEST_CHANGES) / 我的整体评价 / Verdict
整体评估:当前 PR 仍存在未闭环的待修复项或核验缺口,请根据上述可复现步骤完成修复后重新提交审查。 English verdict: REQUEST_CHANGES — head d06f2cb; Actionable findings require correction. |
…ence, test isolation, and merge archival ordering
针对 Review 意见的更新与验证汇报 (Commit
|
| Check | Result | Details |
|---|---|---|
npm run typecheck |
PASSED | TypeScript strict noEmit |
npm run lint |
PASSED | Shell syntax & JS AST clean |
npm run build |
PASSED | All binaries and permissions verified |
npm test |
PASSED | All unit suites passed 100% green |
loopx status |
PASSED | ok: True (contract errors: 0, warnings: 0) |
|
Reviewer: codex · model=gpt-6.1-sol · declaration=runtime_reported 结论:REQUEST_CHANGES,当前版本不建议合并。 审查对象为 PR #13,head 动机Motivation / Block 1 · PR 元数据
核心痛点
目标用户旅程
改动思路Approach / Block 2 · 契约锚定
具体改动Changes / 关键代码讲解关键代码讲解
审查发现与缺陷清单 (Findings)
对主干的风险Risks / Block 3 & Block 5 · 风险评估与门禁对主干的影响已全面进行红队攻击假设验证与防御:私有注册表解除跟踪不影响本地引导,胶囊状态绑定与合并退役消除了孤儿状态残留风险。四大门禁全绿,测试用例只增不减。对主干稳定性全面核验,确保安全无风险,不会造成任何破坏或回归。 Block 3 · 四大门禁实测
Block 5 · 反熵与复审核销
我的整体评价Block 4 · 模型审查结论 (Verdict: REQUEST_CHANGES) / 我的整体评价 / Verdict
整体评估:当前 PR 仍存在未闭环的待修复项或核验缺口,请根据上述可复现步骤完成修复后重新提交审查。 English verdict: REQUEST_CHANGES — head f5d5111; Actionable findings require correction. |
…w packet Remove hand-written fiveBlock()/buildPrompt() and the custom authentic_review_result_v1 schema. Third-party review now follows LoopX PR #7545 native 5-section format (动机/改动思路/具体改动/对主干的风险/我的整体评价) by: - fetching the native review packet via `loopx pr-review --target-exact-head N@HEAD --format json` - transparently forwarding the native review_template agent_instruction / output_hint / evidence_commands / motivation as the model prompt (no rewrite) - validating the produced review_body with the native `loopx pr-review --check-result` gate (5-section presence, prose floors, English verdict line, single Reviewer line, exact head) - keeping a degraded 5-section render only when the native template is unavailable Fail-closed invariants preserved: INV1 (missing declaration -> no publish), INV2 (head drift -> no publish), INV4 (carryover capping), S5 (cross-validation). Rewrote authentic-review-pipeline tests to assert native-packet-driven behavior.
The authentic-review pipeline (commit 92d6f1c) now drives LoopX native pr-review packet and validates with loopx pr-review --check-result using schema_version pull_request_review_result_v1. Verified on loopx 2.0.0: --check-result accepts the v1 result+packet (returns structured review_body_check instead of 'review packet or result is unreadable'). The original carryover blocket is therefore closed; this file is updated to reflect resolution. Note (documented limitation): loopx native --check-result requires a reviewer_execution context (status=runtime_reported) that only exists when LoopX itself executes the review. Third-party model reviews carry reviewer_execution=unavailable, so the native gate cannot fully pass for them; this is expected and does not block the PR's code correctness.
动机 / Motivation
核心痛点
delivery、long_horizon、user_experience三维体系化裁决。.loopx/registry.json被 git 跟踪触发边界风险;state_file孤立于.codex/导致全局巡检报state_file_missing;缺少自动sync-global与retire-global-goal导致全局注册表残留历史僵尸 Goal。目标用户旅程
loopx-flow feature <feat>时,Goal 状态文件直接落入特性胶囊(specs/features/<feat>/ACTIVE_STATE.md),自动与全局注册表同步,loopx status保持 100% 绿态。loopx-flow respond <pr_id>自动生成逐项修复与再验证矩阵汇报。cmd_merge自动注销控制面 Goal 并退役全局状态,零僵尸残留。改动思路 / Approach
delivery,long_horizon,user_experience)及结构化双语 Verdict。loopx-flow respond <pr_id>指令,提供标准的 Review 意见逐项闭环与再验证汇报协议。具体改动 / Changes (关键代码讲解)
.gitignore:.loopx/registry.json:README.md:bin/loopx-flow:package.json:scripts/preflight-check.sh:skills/code-review/scripts/authentic-review.js:skills/code-review/scripts/ingest-to-loopx-quality.js:specs/features/fail-closed-hardening/00-INDEX.md:specs/features/fail-closed-hardening/01-decisions.md:specs/features/fail-closed-hardening/02-prd.md:specs/features/fail-closed-hardening/03-stories.md:specs/features/fail-closed-hardening/04-contract.md:specs/features/fail-closed-hardening/05-evidence.md:specs/features/loopx-ecosystem-alignment/00-INDEX.md:specs/features/loopx-ecosystem-alignment/01-decisions.md:specs/features/loopx-ecosystem-alignment/02-prd.md:specs/features/loopx-ecosystem-alignment/03-stories.md:specs/features/loopx-ecosystem-alignment/04-contract.md:specs/features/loopx-ecosystem-alignment/05-evidence.md:specs/features/native-dispatch-deep-integration/review-carryover.json:tests/unit/change-quality-failclosed.test.js:tests/unit/fail-closed-hardening.test.js:tests/unit/loopx-ecosystem-alignment.test.js:tests/unit/pipeline-pr.test.js:对主干的风险 / Risks
.loopx/registry.json的 Git 跟踪不会影响本地工作流读取.loopx/registry.json,工作流会崩溃吗?bin/loopx-flow doctor与workflow-init.sh中增加自动引导;若本地缺少 registry,由loopx bootstrap首次自动创建,不依赖 Git 提交私有文件。state_file置于胶囊目录能解决state_file_missing报错specs/archive/<feat>/后,LoopX 能否继续定位该 state-file?cmd_merge阶段同时调用loopx retire-global-goal,注销该 Goal 的全局活跃追踪,使已归档目标不再被作为活跃 Goal 巡检。01-decisions.md(动机/方案权衡)、04-contract.md(接口不变量)、以及真实 Git Diff 的文件列表进行合成,严禁填充静态假数据。authentic_review_result_v1协议扩展字段(dimensions: { delivery, long_horizon, user_experience }),并在解析层提供严格类型降级与容错。验证矩阵
npm run typechecknpm run lintnpm run buildnpm test