Skip to content

Set the KHIOPS_PROC_NUMBER env var for each training run using the value of max_cores - #623

Open
tramora wants to merge 1 commit into
mainfrom
max-cores-allocated
Open

tramora wants to merge 1 commit into
mainfrom
max-cores-allocated

Conversation

@tramora

@tramora tramora commented Sep 20, 2026 •

Copy link
Copy Markdown
Collaborator
  • the allocated number of CPU cores can never be greater than the value of max_cores

Fixes #585


Implementation details :


TODO Before Asking for a Review

  • Rebase your branch to the latest version of main (or main-v10)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, markdown files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

@tramora
tramora force-pushed the max-cores-allocated branch from b2f355a to e532ce2 Compare September 22, 2026 09:53
@tramora
tramora requested a review from popescu-v September 22, 2026 09:54
Comment thread khiops/core/internals/runner.py Outdated
Comment thread tests/test_khiops_integrations.py Outdated

@popescu-v popescu-v left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments.

@tramora
tramora force-pushed the max-cores-allocated branch from e532ce2 to e39c91e Compare September 28, 2026 07:14
…value of `max_cores`

- the pre-allocated number of CPU cores can never be greater than the value of `max_cores`
- the KhiopsLocalRunner accepts a 'private' local environment so that the `max_cores` value is valid only for the run

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use KHIOPS_PROC_NUMBER when max_cores is set

2 participants