refactor(cloud-agent-next): consolidate creation ownership - #5967
Open
eshurakov wants to merge 2 commits into
Open
refactor(cloud-agent-next): consolidate creation ownership#5967eshurakov wants to merge 2 commits into
eshurakov wants to merge 2 commits into
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Previous Review Summary (commit ea4e7a6)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit ea4e7a6)Status: No Issues Found | Recommendation: Merge Files Reviewed (31 files)
Reviewed by grok-4.6 · Input: 69K · Output: 5.8K · Cached: 204.7K Review guidance: REVIEW.md from base branch |
Drop the handler-shape AST check. Keep the duplication ratchet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
session-creation-preflight.tsas the single request-scoped owner for organization membership, repository access, profile resolution, mode validation, endpoint validation, and prompt-only model validation. Start and prepare pass its resolved request to registration.jscpd@5.0.16production scanning with fingerprinted, bounded exceptions, plus TypeScript architecture checks for preflight ownership and bypasses. Both checks and their fixtures run in the cloud-agent CI job.Verification
pnpm --filter cloud-agent-next run typecheckpnpm --filter cloud-agent-next run lint— 0 warnings/errorspnpm --filter cloud-agent-next run format:checkpnpm --filter cloud-agent-next run test:checkers— 32 testspnpm --filter cloud-agent-next run check:architecturepnpm --filter cloud-agent-next run check:duplication— 2 bounded exceptions, no new duplicationnode --test scripts/changes-filter-retry.test.mjs— 7 testspnpm --filter cloud-agent-next test:all— unit 5,792 passed / 3 skipped; Worker integration 627 passed; wrapper 1,192 passedses_f7f6f9f00fffJ07y555Z0OMpxYand showed the prompt plusEnvironment preparedwithout creation/auth/model/repository errorsUnit/integration tests still mock some PostgreSQL, model HTTP, Durable Object, sandbox, and process boundaries. Browser E2E is the real user-visible start-path proof. No deployment was attempted.