Skip to content

fix(cloud-agent-next): isolate control-event retirement - #6002

Merged
eshurakov merged 1 commit into
mainfrom
eshurakov/control-outbox-isolation-cleanup
Sep 10, 2026
Merged

fix(cloud-agent-next): isolate control-event retirement#6002
eshurakov merged 1 commit into
mainfrom
eshurakov/control-outbox-isolation-cleanup

Conversation

@eshurakov

Copy link
Copy Markdown
Contributor

Summary

  • Isolate control-event retirement so one root cannot retire work that still belongs to another.
  • Stack root (empty control-outbox-isolation skipped).

Test plan

  • Existing cloud-agent-next control-plane unit tests

@kilo-code-bot

kilo-code-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: 1 Issue Found | Recommendation: Address before merge

Executive Summary

Root-scoped cleanup still skips native abort when a descendant lives in another directory, so this session's native work can keep running on a shared runtime.

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0

Fix these issues in Kilo Cloud

Issue Details (click to expand)

WARNING

File Line Issue
services/cloud-agent-next/wrapper/src/control/session-operation-cleanup.ts 119 Root-scoped cleanup skips native abort when a descendant lives in another directory
Files Reviewed (14 files)
  • services/cloud-agent-next/wrapper/src/control/control-event-transport.ts
  • services/cloud-agent-next/wrapper/src/control/control-event-transport.test.ts
  • services/cloud-agent-next/wrapper/src/control/main.ts
  • services/cloud-agent-next/wrapper/src/control/operation-registry.ts
  • services/cloud-agent-next/wrapper/src/control/operation-registry.test.ts
  • services/cloud-agent-next/wrapper/src/control/sandbox-control-handlers.ts
  • services/cloud-agent-next/wrapper/src/control/sandbox-control-handlers.test.ts
  • services/cloud-agent-next/wrapper/src/control/session-operation-cleanup.ts - 1 issue
  • services/cloud-agent-next/wrapper/src/control/session-operation-cleanup.test.ts
  • services/cloud-agent-next/wrapper/src/control/session-operation-cleanup-proof.test.ts
  • services/cloud-agent-next/wrapper/src/control/session-operation.ts
  • services/cloud-agent-next/wrapper/src/control/session-operation.test.ts
  • services/cloud-agent-next/wrapper/src/control/worktree-runtime.ts
  • services/cloud-agent-next/wrapper/src/control/worktree-runtime.test.ts
Previous Review Summary (commit 68ad205)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 68ad205)

Status: 1 Issue Found | Recommendation: Address before merge

Overview

Severity Count
CRITICAL 0
WARNING 1
SUGGESTION 0

Fix these issues in Kilo Cloud

Issue Details (click to expand)

WARNING

File Line Issue
services/cloud-agent-next/wrapper/src/control/session-operation-cleanup.ts 119 Root-scoped cleanup skips native abort when a descendant lives in another directory
Files Reviewed (14 files)
  • services/cloud-agent-next/wrapper/src/control/control-event-transport.ts
  • services/cloud-agent-next/wrapper/src/control/control-event-transport.test.ts
  • services/cloud-agent-next/wrapper/src/control/main.ts
  • services/cloud-agent-next/wrapper/src/control/operation-registry.ts
  • services/cloud-agent-next/wrapper/src/control/operation-registry.test.ts
  • services/cloud-agent-next/wrapper/src/control/sandbox-control-handlers.ts
  • services/cloud-agent-next/wrapper/src/control/sandbox-control-handlers.test.ts
  • services/cloud-agent-next/wrapper/src/control/session-operation-cleanup.ts - 1 issue
  • services/cloud-agent-next/wrapper/src/control/session-operation-cleanup.test.ts
  • services/cloud-agent-next/wrapper/src/control/session-operation-cleanup-proof.test.ts
  • services/cloud-agent-next/wrapper/src/control/session-operation.ts
  • services/cloud-agent-next/wrapper/src/control/session-operation.test.ts
  • services/cloud-agent-next/wrapper/src/control/worktree-runtime.ts
  • services/cloud-agent-next/wrapper/src/control/worktree-runtime.test.ts

Reviewed by grok-4.6 · Input: 113.2K · Output: 5.8K · Cached: 158.8K

Review guidance: REVIEW.md from base branch main

@eshurakov
eshurakov force-pushed the eshurakov/control-outbox-isolation-cleanup branch from 68ad205 to d03f375 Compare September 9, 2026 18:26

@iscekic iscekic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@eshurakov
eshurakov added this pull request to stack #6038 September 10, 2026 07:15
@eshurakov
eshurakov merged commit 6fcea06 into main Sep 10, 2026
26 of 27 checks passed
@eshurakov
eshurakov deleted the eshurakov/control-outbox-isolation-cleanup branch September 10, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants