fix(cloud-agent-next): isolate scoped Stop across the service boundary - #6005
Merged
eshurakov merged 2 commits intoSep 10, 2026
Conversation
eshurakov
force-pushed
the
eshurakov/control-outbox-isolation-integration
branch
from
September 9, 2026 18:26
c4f0c5d to
70f6a25
Compare
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of the wrangler catalog pin to 4.112.0 (workspace + lockfile) with high confidence and no new high-severity defects. Files Reviewed (2 files)
Previous Review Summaries (2 snapshots, latest commit 88b903a)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit 88b903a)Status: No Issues Found | Recommendation: Merge Executive SummaryIncremental review of the follow-up Stop isolation fixes (cleanup-vs-fullCleanup wait, delayed shared-root abort acknowledgment, and detach wrapping) with high confidence that the changed production paths are correct. Files Reviewed (3 files)
Previous review (commit 70f6a25)Status: No Issues Found | Recommendation: Merge Executive SummaryReviewed scoped Stop isolation across the sandbox-control service boundary (abort-result protocol, root-vs-runtime cleanup, per-root retirement claims, and outbox lanes) with high confidence that the changed production paths do not introduce new high-severity defects. Files Reviewed (31 files)
Reviewed by grok-4.6 · Input: 124.5K · Output: 5.1K · Cached: 186.9K Review guidance: REVIEW.md from base branch |
eshurakov
force-pushed
the
eshurakov/control-outbox-isolation-integration
branch
from
September 9, 2026 19:06
70f6a25 to
0e214a6
Compare
Release operation-only root cleanup without fencing sibling chats, keep per-root claims from retiring a successor, and reject root+quiescence on the strict abort-result reader. Preserve shared-root retirement without a kilo runtime, detach terminals only after a successful abort retirement, and cover worktree/terminal abort paths in unit tests.
eshurakov
force-pushed
the
eshurakov/control-outbox-isolation-integration
branch
from
September 9, 2026 19:22
0e214a6 to
88b903a
Compare
eshurakov
added this pull request to stack #6038
September 10, 2026 07:15
eshurakov
deleted the
eshurakov/control-outbox-isolation-integration
branch
September 10, 2026 07:17
iscekic
added a commit
that referenced
this pull request
Sep 10, 2026
Sync with main and regenerate pnpm-lock.yaml. Main downgraded the wrangler catalog to 4.112.0 (#6005); the stale branch lockfile made --frozen-lockfile fail on the PR merge ref with ERR_PNPM_LOCKFILE_MISSING_DEPENDENCY.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan