feat(cloud-agent-next): settle control-plane git refs, callbacks, and runtime death - #6026
Merged
Conversation
4.127.1 dies locally with ProxyWorker Network connection lost after sandbox attach and callback fetch.
… runtime death Fetch synthetic review refs exactly and check out FETCH_HEAD. Attach failures carry bounded Git detail on the originating message. Control-plane callbacks use a pending-only Durable Object outbox. Process death proof no longer depends on cgroup rmdir. Local E2E can reuse the seeded GitHub user and prepareSession callbackTarget.
eshurakov
force-pushed
the
eshurakov/playful-cinder
branch
from
September 9, 2026 19:38
84eb708 to
8b05dbd
Compare
…rrors Attach already reports git diagnostic detail via formatGitResultFailure. Update the unit assertion so CI matches that message.
… and alarm setup Exhausted attach rejections now fail the originating message. Pause alarm setup on storage.getAlarm so a mid-setup accepted-message change is observable.
CI runners cannot open cgroup.procs. Match sibling tests and skip when containment is unavailable instead of failing the wrapper suite.
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Previous Review Summary (commit d9beb36)Current summary above is authoritative. Previous snapshots are kept for context only. Previous review (commit d9beb36)Status: 1 Issue Found | Recommendation: Address before merge Overview
Issue Details (click to expand)WARNING
Files Reviewed (33 files)
Reviewed by grok-4.6 · Input: 46.2K · Output: 8.8K · Cached: 305.4K Review guidance: REVIEW.md from base branch |
…elete Successful process-death observation stays joinable, and directory deletion treats an already-removed entry as retired so homes are still cleaned up.
marius-kilocode
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Control-plane attach can check out synthetic review refs (
refs/pull/*/head) via exact fetch +FETCH_HEAD, and attach failures keep bounded Git detail on the originating message.Callbacks for control-plane sessions use a pending-only Durable Object outbox (not the legacy queue). Runtime death proof no longer depends on cgroup rmdir succeeding.
Local E2E can reuse the
cloud-worktree-setupGitHub user andprepareSessioncallbackTarget. Wrangler is pinned to 4.112.0 because 4.127.1 dies locally with ProxyWorkerNetwork connection lostafter attach/callback fetch.Test plan
--api=legacy, seeded GitHub user,na2-org/hi-how-are-you:refs/pull/999999/head+ failed callback76ac6cb5…