Skip to content

fix(sdk): accept CLI interleaved fields in the remote model catalog - #6029

Merged
iscekic merged 1 commit into
mainfrom
fix/mobile-remote-cli-model-change
Sep 10, 2026
Merged

fix(sdk): accept CLI interleaved fields in the remote model catalog#6029
iscekic merged 1 commit into
mainfrom
fix/mobile-remote-cli-model-change

Conversation

@iscekic

@iscekic iscekic commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

One mismatched interleaved.field used to reject the whole CLI catalog. The remote model picker then stayed disabled.

What

  • Accept any non-empty interleaved.field string from CLI 7.5+.
  • Keep boolean interleaved as before.
  • Add a catalog parse test for reasoning, reasoning_content, reasoning_details, and reasoning_text.

Why

The picker discards interleaved after parse. The old enum (reasoning_content | reasoning_details) did not match CLI values such as reasoning and reasoning_text. Parse failure left protocol unknown, so the chip showed the model id and taps did nothing.

Report: remote CLI session on Windows 11 PowerShell, CLI 7.5.9, latest app. Screenshot showed muse-spark-1.3-contributor truncated on the composer chip.

Test

pnpm --filter @kilocode/cloud-agent-sdk exec jest --testPathPatterns=remote-model-catalog.test

@iscekic iscekic self-assigned this Sep 9, 2026
@kilo-code-bot

kilo-code-bot Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Schema widening for CLI interleaved.field plus catalog, transport, and picker regression tests look correct after rebase.

Files Reviewed (4 files)
  • apps/mobile/src/lib/use-session-model-options.test.ts
  • packages/cloud-agent-sdk/src/cli-live-transport.test.ts
  • packages/cloud-agent-sdk/src/remote-model-catalog.test.ts
  • packages/cloud-agent-sdk/src/schemas.ts
Previous Review Summaries (2 snapshots, latest commit 2b9879e)

Current summary above is authoritative. Previous snapshots are kept for context only.

Previous review (commit 2b9879e)

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental tests for CLI interleaved catalog parse, v1 transport publish, and picker lock-on-unknown look correct.

Files Reviewed (3 files)
  • apps/mobile/src/lib/use-session-model-options.test.ts
  • packages/cloud-agent-sdk/src/cli-live-transport.test.ts
  • packages/cloud-agent-sdk/src/remote-model-catalog.test.ts

Previous review (commit 0f88436)

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • packages/cloud-agent-sdk/src/schemas.ts
  • packages/cloud-agent-sdk/src/remote-model-catalog.test.ts

Reviewed by grok-4.6 · Input: 124.9K · Output: 7.7K · Cached: 352.4K

Review guidance: REVIEW.md from base branch main

@iscekic
iscekic marked this pull request as draft September 10, 2026 00:37
@iscekic
iscekic force-pushed the fix/mobile-remote-cli-model-change branch from af73376 to 2523f3e Compare September 10, 2026 01:16
@iscekic
iscekic marked this pull request as ready for review September 10, 2026 01:28
@iscekic iscekic added the human-ready The PR is ready for human review. label Sep 10, 2026
@iscekic
iscekic requested a review from eshurakov September 10, 2026 01:41
@iscekic
iscekic merged commit 7feee32 into main Sep 10, 2026
25 checks passed
@iscekic
iscekic deleted the fix/mobile-remote-cli-model-change branch September 10, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

human-ready The PR is ready for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants