test(mobile-app): pin one-tap session send and harden flaky test timeouts - #6034
Open
iscekic wants to merge 1 commit into
Open
test(mobile-app): pin one-tap session send and harden flaky test timeouts#6034iscekic wants to merge 1 commit into
iscekic wants to merge 1 commit into
Conversation
…outs Fix the mobile session send button that requires two taps. Surface: mobile-app. On the session page, the send button sits to the right of the microphone icon and the composer. Expected: One tap sends the current message exactly once. Actual: The user must tap the send button twice. Reproduce this through the normal session composer before changing product code. Find and fix the shared cause across affected session flows. Prove the first tap sends with the keyboard open and with the keyboard closed. Cover focus changes, empty input, and duplicate-send prevention with focused regression checks. Preserve microphone behavior and existing send states. Put local end-to-end (E2E) device proof in the pull request (PR) body. Use temporary test support outside the product diff. Do not commit fixtures, E2E-only code, or test-only runtime flags. Do not leave follow-ups. Let the workflow open and maintain the PR. Finish only after current-head continuous integration (CI) is green and Kilobot recommends Merge.
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by grok-4.6 · Input: 241.9K · Output: 15.9K · Cached: 596.1K Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog for users
Changelog for maintainers
markdown-renderer.test.tssets a file-wide 30 s test timeout; importingreact-native-markedexceeds the 5 s default under full parallelism.auth-context.test.tsxgets the same 30 s timeout, wall-clock settle budgets instead of iteration counts, and 60 s per-test timeouts for retry backoffs.E2E proof
Recording of the verified flow (waits trimmed)
e1-send-keyboard-open.mp4.trim.mp4
E2E proof — log excerpts
/Users/igor/.local/share/kwf/sections/fix-the-mobile-session-send-5bb4/e2e-mobile-app/e1-kb-closed.log/Users/igor/.local/share/kwf/sections/fix-the-mobile-session-send-5bb4/e2e-mobile-app/e1-kb-open.log/Users/igor/.local/share/kwf/sections/fix-the-mobile-session-send-5bb4/e2e-mobile-app/e1-empty.log/Users/igor/.local/share/kwf/sections/fix-the-mobile-session-send-5bb4/e2e-mobile-app/e1-dup.log/Users/igor/.local/share/kwf/sections/fix-the-mobile-session-send-5bb4/e2e-mobile-app/e1-focus.log/Users/igor/.local/share/kwf/sections/fix-the-mobile-session-send-5bb4/e2e-mobile-app/e1-mic.logOwner request