Skip to content

Apply documented defaults to format options - #1353

Open
JordanNoone wants to merge 1 commit into
mainfrom
codex/default-format-options-1300
Open

Apply documented defaults to format options#1353
JordanNoone wants to merge 1 commit into
mainfrom
codex/default-format-options-1300

Conversation

@JordanNoone

Copy link
Copy Markdown
Contributor

Summary

  • apply existing defaults when OBJ, PLY, STL, and glTF option fields are omitted
  • add a regression test for minimal import and export payloads
  • regenerate OpenAPI so defaulted fields are no longer marked required

Tests

  • cargo +1.96.0 test -p kittycad-modeling-cmds documented_format_defaults_are_applied_when_omitted
  • EXPECTORATE=overwrite cargo +1.96.0 test -p kittycad-modeling-cmds --all-features test_openapi -- --nocapture
  • cargo +1.96.0 clippy -p kittycad-modeling-cmds --tests -- -D warnings

Closes #1300

@codecov

codecov Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@dd11426). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1353   +/-   ##
=======================================
  Coverage        ?   36.12%           
=======================================
  Files           ?       36           
  Lines           ?     1813           
  Branches        ?        0           
=======================================
  Hits            ?      655           
  Misses          ?     1158           
  Partials        ?        0           
Flag Coverage Δ
unittests 36.12% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JordanNoone
JordanNoone marked this pull request as ready for review August 31, 2026 02:13
@JordanNoone
JordanNoone requested review from adamchalmers and alteous and removed request for alteous August 31, 2026 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Documented import/export defaults are required on the wire (OBJ/PLY/STL/glTF lack #[serde(default)])

1 participant