Skip to content

Draft API for assembly blocks - #1362

Draft
adamchalmers wants to merge 2 commits into
mainfrom
achalmers/assembly
Draft

Draft API for assembly blocks#1362
adamchalmers wants to merge 2 commits into
mainfrom
achalmers/assembly

Conversation

@adamchalmers

Copy link
Copy Markdown
Collaborator

Assembly block MVP needs 3 things:

  • Moving bodies into the assembly
  • Creating mate connectors
  • Applying constraints to mate connectors

One nice-to-have that I've called out in a TODO:

  • Translate/rotate calls where the engine persists its solutions into the KCL AST, ensuring warm solves.
  • I don't know how the engine would send this back to KCL -- presumably a translate + rotate for each body in solved system, but what coordinate system would it be in? Scene global, or relative to something? Currently KCL translate has two coordinate frames available, the global scene, and the body's sketch's local system.

@codecov

codecov Bot commented Sep 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@001252d). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1362   +/-   ##
=======================================
  Coverage        ?   34.09%           
=======================================
  Files           ?       37           
  Lines           ?     1833           
  Branches        ?        0           
=======================================
  Hits            ?      625           
  Misses          ?     1208           
  Partials        ?        0           
Flag Coverage Δ
unittests 34.09% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

pub struct MateFrameCreate {
/// What to create the mate frame on.
pub on: MateFrameOn,
}

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could add options here to reorient the mate frame, e.g. translating it, rotating it, flipping the major/minor axes. WDYT David?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant