fix(DataArray): validate structural mutations and preserve ranges - #3634
Open
daker wants to merge 1 commit into
Open
fix(DataArray): validate structural mutations and preserve ranges#3634daker wants to merge 1 commit into
daker wants to merge 1 commit into
Conversation
daker
force-pushed
the
dataarray-fixes
branch
2 times, most recently
from
September 5, 2026 14:14
479e311 to
514e859
Compare
Collaborator
Author
finetjul
reviewed
Sep 7, 2026
Prevent invalid tuple insertions, resize operations, and component counts from corrupting array invariants. Invalidate cached ranges after mutations and preserve independently cloned ranges in newClone() and deepCopy(). Require setData() to receive a typed array. Fixes Kitware#3628
daker
force-pushed
the
dataarray-fixes
branch
from
September 7, 2026 22:03
514e859 to
040c51b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Prevent invalid tuple insertions, resize operations, and component counts from corrupting array invariants. Invalidate cached ranges after mutations and preserve independently cloned ranges in newClone() and deepCopy().
Require setData() to receive a typed array.
Fixes #3628
Results
Changes
PR Checklist