fix(renderwindowinteractor): do not trigger mouse press event for the… - #3635
Merged
Merged
Conversation
finetjul
force-pushed
the
no-press-event-for-first-press
branch
2 times, most recently
from
September 8, 2026 07:34
7ec4e85 to
acb8c08
Compare
… first mouse down button The RWI may not catch a mouse press event (e.g. because it was caught by a div over the RW), in that case the "chorded event" must not apply and moving the mouse over the RW must not trigger a mouse down event
finetjul
force-pushed
the
no-press-event-for-first-press
branch
from
September 8, 2026 10:14
acb8c08 to
0ec7623
Compare
|
🎉 This PR is included in version 36.13.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… first mouse down button
The RWI may not catch a mouse press event (e.g. because it was caught by a div over the RW), in that case the "chorded event" must not apply and moving the mouse over the RW must not trigger a mouse down event
Context
If you add a slider over the RW, a click and drag on the slider may trigger some mouse move events on the RW if the mouse moves outside the slider. Currently, due to the chorded event mechanism, the first mouse move event was triggering a mouse press event that was then enabling the interactor style to rotate the camera while the slider was being interacted with.
Results
The interactor style interaction use case described above no longer happens because the mouse press event is no longer triggered.
Changes
The chorded event mechanism is not applied for the "first" button(s), only when there is at least one button down.
PR Checklist