Fix the crash after adding the Windows 11 menu entry, and the donut on a drag without files - #20
Merged
Merged
Conversation
GetPackagePathByFullName2 was imported from kernel32.dll, which doesn't export it. The call only happens once the package is registered, so adding the entry crashed Filee right after Windows accepted it, and the General page threw on every later visit. It is now imported from its API set, the package state and menu commands never take the app down, and a test checks that every native import exists in the DLL it names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The gesture is detected before anyone knows what is dragged, so a modifier + drag of text or a rubber-band selection opened an empty ring. The window now waits invisibly at the cursor and the donut appears only when files enter; otherwise it closes quietly when the button is released. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two bugs reported on 1.1.0:
GetPackagePathByFullName2is not exported bykernel32.dll(only bykernelbase.dll), so reading where theregistered package points threw
EntryPointNotFoundExceptiononce the package existed — first inside the addcommand (an unhandled exception on that path ends the app), then every time the General page read the state.
api-ms-win-appmodel-runtime-l1-1-3.dll.General page reports a failed add/remove instead of crashing.
LibraryImportinNativeMethodsmust exist in the DLL it names (it fails with the old import).at once so Explorer can drop onto it, but it stays invisible until files actually enter it.
Tests
dotnet testpasses, including the newExplorerMenuTestsandDonut_toolbar_waits_for_files_in_drag_mode.🤖 Generated with Claude Code