refactor: enforce all-mode Python typing and full Ruff preview - #371
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7c9917f714
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "approved_by": "swkeever", | ||
| "approved_at": "2026-09-24", | ||
| "approval_evidence": "User explicitly approved all six exact subprocess import scopes in the Codex strict SDK guardrails conversation on 2026-09-24." |
There was a problem hiding this comment.
This Codex-authored change adds seven quality-policy exceptions and records swkeever as their approver based only on a Codex conversation; because the policy checker pins and accepts these records immediately, this effectively approves suppressions on the human reviewer's behalf. Leave the new exceptions unapproved until the human reviewer supplies and records the approval through the repository's review process.
AGENTS.md reference: AGENTS.md:L6-L8
Useful? React with 👍 / 👎.
| client.capture_session_binding() | ||
| ) | ||
| self._fallback_token: str = client.function_token() |
There was a problem hiding this comment.
Functions remains a public class whose constructor says it binds to a Volcano client, but Functions(VolcanoClient(...)).invoke(...) now reaches this call and raises AttributeError because VolcanoClient provides _capture_session_binding() and _function_token(), not the new public capability methods. Existing callers that instantiate the facade directly therefore break; adapt a VolcanoClient to its internal context in the constructor or keep accepting the former context shape.
Useful? React with 👍 / 👎.
|
Restored direct construction with Exception records now distinguish explicit task authorization from GitHub review approval. The user explicitly approved the six subprocess import scopes and later delegated pragmatic compatibility/tool exceptions. No human repository review is being asserted or submitted. The two private factory returns are exact scoped Ruff/Basedpyright exceptions with negative fixtures; all other private-access checks remain active. The mutation report gate now asks pinned Mutmut's own generator for candidates instead of inferring mutability from an AST. Missing nonempty reports still fail. Added assertions cover the database, realtime, and durable survivors found by the first complete matrix. |
|
@codex review |
🛡️ Codex Security Review · Automatically triggeredSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Enable basedpyright
all, Ruff's complete pinned preview rules, and global strict mypy Any checks across runtime code, tests, contract bindings, examples, scripts, and local stubs. Remove broad Any/private-access exemptions without a diagnostic baseline.VolcanoClientconstruction of client-bound facades and database builders. Channels retain the documentedRealtime.channel()factory; its former constructor required private lifecycle configuration.UUID | strwire inputs through pinned OpenAPI templates. Regeneration comparisons verify generated output.Validation:
uv run --locked poe checkspasses with 2,322 tests and 100% coverage across 5,715 runtime statements and 1,344 branches. Ruff ALL+preview, strict mypy, basedpyright all, dependency audit, generated provenance, wheel/sdist consumer smoke tests, optional-dependency environments, and installed-package type completeness (100%) pass. Direct constructor examples also type-check against the installed wheel. The complete native mutation matrix and final Codex review must pass before merge; shared live contract acceptance remains coordinated with Hosting.