Repository navigation
Fix mpi4py include path in CO_SIM_IO_BUILD_PYTHON_MPI4PY_INTERFACE - #383
Merged
Merged
Conversation
loumalouomega
requested review from
philbucher and
pooyan-dadvand
as code owners
October 26, 2026 09:42
philbucher
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CO_SIM_IO_BUILD_PYTHON_MPI4PY_INTERFACEnever added the mpi4py include directory.mpi4py_interface.cppincludes<mpi4py/mpi4py.h>, so the build only worked if the caller passed-isystem <site-packages>/mpi4py/includethroughCMAKE_CXX_FLAGS. The CI job currently does that as a workaround.Changes
mpi4py.get_include(). It usesPython_EXECUTABLEand falls back toPYTHON_EXECUTABLE, because pybind11 may set either.PyCoSimIOMPI_mpi4pyInterfaceas aSYSTEMinclude directory.Testing
-DCO_SIM_IO_BUILD_PYTHON=ON -DCO_SIM_IO_BUILD_MPI=ON -DCO_SIM_IO_BUILD_PYTHON_MPI4PY_INTERFACE=ONand noCMAKE_CXX_FLAGS.PyCoSimIOMPI_mpi4pyInterfacesuccessfully.