Conversation
Member
Author
|
@tomeichlersmith do you have any other idea why this situation happened? If this is just what we have, I'd like to merge this w/o waiting 3 days and test it on |
Member
|
I have no idea why it happened, but I'm fine with you making hot-fixes onto I would just delete the old v6.0.0 release and make a new one. The build failing means that there isn't event a v6.0.0 tag on DockerHub for folks to pull from. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a 100% how this happened (*) but on trunk the build failed:
https://github.com/LDMX-Software/dev-build-context/actions/runs/26589468131
(*) I think in the PR we prob still had a cached layer for the LHAPDF
In this PR now I enforce LHAPD uses gcc13 too