fix: update stale playwright.dev sidebar locator in sample tests - #14
Open
utchimakali-m wants to merge 1 commit into
Open
fix: update stale playwright.dev sidebar locator in sample tests#14utchimakali-m wants to merge 1 commit into
utchimakali-m wants to merge 1 commit into
Conversation
The playwright.dev docs sidebar renamed "Components (experimental)" to "Component testing", so the locator in SampleTest1 and SampleTest2 no longer matched and both matrix tasks failed at the test level. Also bump the Windows pre step's npm playwright install from 1.23.0 to 1.57.0 to match pom.xml and yaml/linux. The tests connect to a remote browser over cdp.lambdatest.com and Java Playwright ships its own driver bundle, so this npm install is unused at runtime -- the bump is for consistency only and was not exercised by the passing run. Verified on HyperExecute win matrix job 8dad8be5: both tasks green, test stage 100% pass. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NkXiQEUJmN37h5tnEX51V4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SampleTest1andSampleTest2both click through the playwright.dev docs sidebar. One of the entries was renamed upstream on the docs site — "Components (experimental)" is now "Component testing" — so this line no longer matches anything and the tests fail at the test level:Changes
text=Component testingin both sample test classes.prestep's npm playwright install from1.23.0to1.57.0, matchingpom.xmland whatyaml/linuxalready uses.Note on the npm bump
The samples connect to a remote browser via
wss://cdp.lambdatest.com/playwright(BaseTest.createConnection), and Java Playwright ships its own driver bundle, so this npm install isn't used at runtime — the bump is purely for consistency withpom.xml. It was not exercised by the verifying run below, which still used1.23.0.yaml/macis also still on1.23.0; I left it alone to keep this diff minimal, happy to align it too if you'd prefer.Verification
HyperExecute win matrix job,
yaml/win/junit_hyperexecute_matrix_sample.yaml:All 10 stages green across both matrix tasks. Not re-verified on linux/mac, though the locator change is platform-independent.
🤖 Generated with Claude Code