Repository navigation
Main CI red post-#1220: golangci-lint flood, npm audit, internal/config integration failures #1223
Description
Main's CI - Build & Test workflow still fails on the current HEAD (4108e51, post #1220 "fix/main-ci-failing-jobs"), run 27325319311. Every open PR inherits these failures, so CI is red regardless of the PR's content. Three independent breakages:
-
Lint Code ("Run golangci-lint" step): a flood of findings across long-unchanged files, e.g. errcheck on
cmd/cleanup-lambda/main.go:78andcmd/configure_azure.go, errorlint oninternal/config/store_postgres.go(many lines) andinternal/api/handler_purchases.go:1383, godot oninternal/testutil/testutil.go. The breadth suggests linter version or config drift (new linters becoming active) rather than new code. Note the repo rule to pin CI tool versions. -
Security Scanning ("Run npm audit (frontend)" step): the job now fails at the frontend npm audit step (the Go scanners pass).
-
Integration Tests ("Run integration tests" step): real failures in
internal/config:TestPostgresStore_UpsertRecommendations_AccountScopedEvictionTestPostgresStore_UpsertRecommendations_AmbientAndRegisteredCoexistTestPostgresStore_PurchaseExecutions/Get_execution_by_ID_-_not_foundfollowed bypanic: runtime error: invalid memory address or nil pointer dereference, failing the whole package.
The pre-commit workflow on main is also red; that one is the gocyclo breakage tracked separately in #1222.
Suggested split: pin/align golangci-lint and reconcile its config; triage the npm audit advisory (upgrade or documented exemption, no blanket --audit-level loosening without justification); fix the internal/config integration tests (the nil-pointer panic looks related to the recent (nil, nil) not-found contract change in 1017f66).
Activity
cristim commentedon Jul 27, 2026
Verification sweep against
main(101f099fb) on 2026-07-27 finds this already resolved.Main CI is green: Lint Code, Security Scanning and Integration Tests all report success on the latest run.
Evidence: run 30296156256 on 101f099.
Recommending close. Reopen if CI regresses.
cristim commentedon Aug 9, 2026
Closing as resolved. Verified rather than assumed.
CI - Build & Testis green onmainacross the last three merges:All three named breakages are addressed:
0 issues.line. (Version drift was the suspected cause in this issue, and pinning is what fixed it.)Two things found while checking, both filed separately rather than folded in here:
Deploy to Azure Container Appshas failed on everymainrun since 2026-07-19: 0 successes in the last 100 runs. It fails at Terraform Apply on a missing custom role definition. This issues premise, "CI is red", turned out to be false for build and test and true for deploy — a distinction nothing surfaces, since the deploy is a separate workflow../...from the root covered only one of them (ci: unit and integration test jobs only run the root module — providers/*, pkg and tests/e2e are never tested #1751). Five modules had tests that had never gated a merge.Reopen if the lint flood recurs; the pinned version is the thing keeping it closed.