Skip to content

fix(security): resolve gosec findings keeping Security Scanning red on main #1354

Closed

Description

@cristim

With govulncheck (#1343) and npm audit (#1345) now green, the Security Scanning job's remaining failure is the gosec static-analysis step. Likely pre-existing gosec debt newly surfaced (earlier steps used to fail first). Run gosec ./... per the CI job config, triage each finding (real vuln vs false positive), fix real ones, and justify suppressions individually with #nosec + reason (no blanket excludes). Part of the main-CI-green effort alongside #1342 (Lint).

Activity

  1. cristim commented on Jul 16, 2026

    @cristim
    MemberAuthor

    Resolved by #1363 (merged): Security Scanning is green on main with all 6 Go modules scanned by pinned gosec v2.26.1. Recommend closing.

  2. cristim commented on Jul 27, 2026

    @cristim
    MemberAuthor

    Verification sweep against main (101f099fb) on 2026-07-27 finds this already resolved.
    Security Scanning is green on main, with gosec pinned at v2.28.0 running across all 6 modules and the codebase carrying 80 #nosec Gxxx annotations in the form standalone gosec honors.
    Evidence: commits 4193ecc, 744b42a, 8cd51ab (PR #1384); main runs 30296156256 and 30292972151 both green.
    Recommending close. Reopen if further gosec debt resurfaces.

  3. cristim commented on Sep 2, 2026

    @cristim
    MemberAuthor

    Verified resolved at 3c0f8ac: the Security Scanning job runs a pinned gosec v2.28.0 across all six Go modules and is green on main (run 33392508823 at this commit). Evidence: .github/workflows/ci.yml:676 (#1363, #1384). Residual axes checked: govulncheck step in the same job also passes; the per-module loop covers pkg, providers/aws, providers/azure, providers/gcp and tests/e2e. Closing as completed; reopen if the behaviour recurs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions