Repository navigation
bug(api/dashboard): calculateCommitmentMetrics does not intersect allowed_accounts for scoped sessions #959
Description
Summary
calculateCommitmentMetrics in handler_dashboard.go queries commitment data (reservations, savings plans) without filtering by the caller's allowed_accounts scope. A scoped session therefore sees commitment metrics aggregated across all accounts, not just the ones it has access to.
Reproduction
- Create a session scoped to a subset of accounts via
allowed_accounts. - Fetch the dashboard endpoint.
- Observe that commitment totals include purchases from accounts outside the scope.
Expected behaviour
Commitment metrics should be restricted to the same account set that governs the rest of the dashboard (the set resolved by resolveDashboardAccountScope).
Notes
resolveDashboardAccountScopealready resolvesaccountUUIDsandaccountExternalIDsfrom the session'sallowed_accounts;calculateCommitmentMetricsneeds to accept and apply both lists when querying.- Deferred from PR fix(api): filter purchases by account UUID AND external id (closes #701, #498, #866) #956 (account-filter dual-column predicate) to keep that PR focused.
Activity
refactor(api,config): revert ExternalIDsByProvider to flat ExternalID…
fix(api): filter purchases by account UUID AND external id (closes #701…
cristim commentedon Jul 27, 2026
Verification sweep against
main(101f099fb) on 2026-07-27 finds this already resolved.calculateCommitmentMetrics now takes and applies the account scope.
Evidence: commit d086575 (#927).
Recommending close.
cristim commentedon Sep 2, 2026
Verified resolved at 3c0f8ac: calculateCommitmentMetrics now takes the dashboard's resolved account UUIDs and per-provider external IDs and applies both when fetching active purchase history, so scoped sessions only aggregate commitments from their allowed accounts. Evidence: internal/api/handler_dashboard.go:69, :633-638 and :677 (#927). Residual axes checked: empty-scope fail-closed branch (:634), external-ID (non-UUID) account path forwarded alongside UUIDs; none found. Closing as completed; reopen if the behaviour recurs.
fix(api): filter purchases by account UUID AND external id (closes #701…