ci: align vet and lint with module loop convention - #2126
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: LeanerCloud/cloud-commitments-cli/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe CI workflow now installs the pinned ChangesCI code checks
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~7 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to The lint and vet workflow changes have no established merge-blocking issue. Complete the hosted Linux checks as part of normal validation. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Align vet and golangci-lint with the workflow's existing
for mod in .convention. The CLI has one module today, so this is a consistency change with unchanged analysis coverage. Future modules still require explicit loop updates.Keep the pinned lint action as installer, its cache path, configuration verification, and ten-minute timeout. Only
.github/workflows/ci.ymlchanges.Validation on macOS with Go 1.26.6 and golangci-lint 2.10.1:
actdry-run stopped while fetching actions; it provides no successful runner simulation. Hosted Linux checks remain required.Independent review: gpt-6-astra, using the user-authorized substitute and local review path, completed three clean plan passes and two clean implementation passes. Final verdict: APPROVED for publication at
1321c11f7af6fd02a67e67bf28dab50c69c5256a, no actionable findings. Reviewer reread the full committed diff, verified the clean tree and workflow byte identity, and reran independent YAML probes and actionlint. Merge remains conditional on required hosted checks.Closes #1478
Summary by CodeRabbit