fix(deps): align standalone provider shared package pins - #159
Merged
Merged
Conversation
Contributor
|
Warning Review limit reached
This review includes 4 billable files and costs up to $1.00.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 37 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 67 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configurationConfiguration used: Repository: LeanerCloud/cloud-commitments-go/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: ⛔ Files ignored due to path filters (3)
📒 Files selected for processing (4)
Comment |
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Provider modules now require the published shared package matching their nullable purchase-cost API and merged deduplication fixes. A standalone provider build/test/tidy step prevents the repository workspace from hiding incompatible declared dependencies.
Root cause and fix
All three providers required a shared package with scalar
PurchaseResult.Cost, while provider source assigns pointers. The committed workspace selected local pkg and masked the mismatch. Update only the three pkg requirements and their checksums tov0.0.0-20260929105827-b3b4cb5e3d80, whose public Origin.Hash matches merged commitb3b4cb5e3d806f479d14e24872dfe57a4201c73f. No replace directives, vendoring, indirect upgrades or source changes.Regression proof
The pre-fix standalone GCP compile fails at computeengine/client.go:748 because
*float64cannot be assigned to scalar Cost. A separate external module importing only providers/gcp at the published base reproduces that same error in the downloaded module. A distinct fresh consumer importing only providers/gcp at candidate22c791e5b39b29264e47b879f4c3e7659e21fe03builds successfully with GOWORK=off and readonly dependencies. It selects providerv0.0.0-20260929111212-22c791e5b39band transitively selects the corrected pkg, with no direct pkg upgrade or replacement.Verification
go test -mod=readonly -race -short -count=1 ./..., vet, golangci-lint 2.10.1, tidy-diff and module checksum verification passed.SKIP=actionlint. Linux workflow execution remains a CI gate; act was not run against the hung daemon.Closes #154