Skip to content

fix(deps): align standalone provider shared package pins - #159

Merged
cristim merged 1 commit into
mainfrom
fix/154-provider-pkg-pins
Sep 29, 2026
Merged

cristim merged 1 commit into
mainfrom
fix/154-provider-pkg-pins

Conversation

@cristim

@cristim cristim commented Sep 29, 2026 •

Copy link
Copy Markdown
Member

Summary

Provider modules now require the published shared package matching their nullable purchase-cost API and merged deduplication fixes. A standalone provider build/test/tidy step prevents the repository workspace from hiding incompatible declared dependencies.

Root cause and fix

All three providers required a shared package with scalar PurchaseResult.Cost, while provider source assigns pointers. The committed workspace selected local pkg and masked the mismatch. Update only the three pkg requirements and their checksums to v0.0.0-20260929105827-b3b4cb5e3d80, whose public Origin.Hash matches merged commit b3b4cb5e3d806f479d14e24872dfe57a4201c73f. No replace directives, vendoring, indirect upgrades or source changes.

Regression proof

The pre-fix standalone GCP compile fails at computeengine/client.go:748 because *float64 cannot be assigned to scalar Cost. A separate external module importing only providers/gcp at the published base reproduces that same error in the downloaded module. A distinct fresh consumer importing only providers/gcp at candidate 22c791e5b39b29264e47b879f4c3e7659e21fe03 builds successfully with GOWORK=off and readonly dependencies. It selects provider v0.0.0-20260929111212-22c791e5b39b and transitively selects the corrected pkg, with no direct pkg upgrade or replacement.

Verification

  • Go 1.26.6, GOWORK=off, all three providers: readonly build, full go test -mod=readonly -race -short -count=1 ./..., vet, golangci-lint 2.10.1, tidy-diff and module checksum verification passed.
  • Workspace provider build and focused AWS recommendations/ElastiCache, GCP computeengine and Azure compute race tests passed.
  • actionlint 1.7.12 with shellcheck and zizmor 1.29.0 passed; applicable pre-commit checks passed. Docker is hung on this host, so its actionlint hook was replaced with the identical native version using SKIP=actionlint. Linux workflow execution remains a CI gate; act was not run against the hung daemon.
  • No cloud calls or purchases were performed.

Closes #154

@cristim cristim added triaged Item has been triaged urgency/this-sprint Within the current sprint priority/p1 Next up; this sprint severity/high Significant harm impact/many Affects most users effort/s Hours type/bug Defect labels Sep 29, 2026
@coderabbitai

coderabbitai Bot commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 4 billable files and costs up to $1.00.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 37 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 67 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: LeanerCloud/cloud-commitments-go/.coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 606c749c-9b7e-475b-bf91-d896c9860175

📥 Commits

Reviewing files that changed from the base of the PR and between b3b4cb5 and 22c791e.

⛔ Files ignored due to path filters (3)
  • providers/aws/go.sum is excluded by !**/*.sum
  • providers/azure/go.sum is excluded by !**/*.sum
  • providers/gcp/go.sum is excluded by !**/*.sum
📒 Files selected for processing (4)
  • .github/workflows/ci.yml
  • providers/aws/go.mod
  • providers/azure/go.mod
  • providers/gcp/go.mod

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/s Hours impact/many Affects most users priority/p1 Next up; this sprint severity/high Significant harm triaged Item has been triaged type/bug Defect urgency/this-sprint Within the current sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(deps): align provider module pkg pins with nullable Cost API

1 participant