ci: align vet and lint with module loop convention - #36
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: LeanerCloud/cloud-commitments-mcp/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour. 📝 WalkthroughWalkthroughThe CI workflow now verifies and runs golangci-lint for each module with a 10-minute timeout and a dedicated cache directory. It also runs ChangesPer-module CI checks
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to The workflow now expresses lint and vet as per-module checks while preserving coverage for this single-module repository. No code-level merge blocker is evident; hosted CI should still confirm runner execution. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Align CI vet and lint with the existing
for mod in .convention used by tests and security scans. Retain the pinned lint action as installer, its cache directory, configuration validation, and the 10-minute lint timeout.This repository currently has one module, so package coverage and diagnostics are unchanged. Future module additions still require updating the explicit module lists.
Validation: executed the actual YAML blocks against the repository with Go 1.26.6 and golangci-lint 2.10.1; diagnostics match baseline. Five shell probes verify invocation arguments, working directory, cache, and failure propagation, including config failure preventing lint. Race tests, build, native workflow lint, and normal pre-commit hooks passed. Local act simulation timed out fetching pinned actions; hosted Linux CI remains required.
Independent gpt-6-astra review, authorized for this session, completed two clean implementation passes and independently exercised the shell probes. Final verdict for
f7a0b52fd6fd22354d90443f4e5a0505b13f94f1: MERGE once required hosted Linux CI passes. The reviewer re-read the complete committed diff, verified identity with the approved staged diff, and reran all five YAML probes and actionlint on this SHA. This is not an Opus review.Closes #21
Summary by CodeRabbit
go vetseparately for each module. Lint checks also use a dedicated cache and a 10-minute timeout. These changes affect automated project checks; no end-user features or behavior changed.