fix(search): reject incomplete AWS recommendation menus

[cristim]

AWS recommendation parsing can reject a malformed detail while returning a successful short menu. Pin the published AWS SDK completeness fix so the existing strict MCP error path rejects incomplete selected and six-combination searches. Valid and genuinely empty results remain successful.

Refs LeanerCloud/cloud-commitments-go#54. The parent issue remains open for the CLI and Platform rollout.

Independent gpt-6-astra review approved exact SHA dee33b0c4900574cd7f97d352b1b9e519ae47ff9 after two source and two index passes. Fresh registered MCP protocol tests passed all eight cases at that SHA using synthetic responses at the SDK HTTP boundary. The same regression fails for all four malformed cases against the parent dependency and a diagnostic-drop mutation; valid/empty controls pass in both probes. This is connected local verification, with no live cloud calls.

Full race tests, build, golangci-lint 2.10.1 and all installed commit hooks passed. Standalone GOWORK=off module selection uses published AWS v0.0.0-20261002152209-006ef5c8d0a2 and pkg v0.0.0-20260929105827-b3b4cb5e3d80, with no replacements. Lint configuration validation could not download its schema in the confined local environment; CI must confirm that check.

Summary by CodeRabbit

• Chores
  • Updated components supporting AWS integrations.
• Tests
  • Expanded checks for AWS recommendation searches with valid, empty, and invalid responses.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: LeanerCloud/cloud-commitments-mcp/.coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 73ab48a8-ea9b-46c0-8aa1-6ffbd493f6df

📥 Commits

Reviewing files that changed from the base of the PR and between b94f5d4 and dee33b0.

⛔ Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

📒 Files selected for processing (2)

• go.mod
• tools/search_recommendations_completeness_test.go

Included review availability: This review used your included allowance. 0 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

---

📝 Walkthrough

Walkthrough

The change updates the AWS SDK and provider dependency declarations. It adds protocol tests for AWS RDS recommendation searches across selected and unselected scopes and multiple response shapes.

Changes

AWS recommendation search

Layer / File(s)	Summary
Module dependency declarations go.mod	The AWS SDK v2 core dependency is direct. The pkg and AWS provider dependencies use newer pseudo-versions.
Recommendation search protocol test tools/search_recommendations_completeness_test.go	The test checks request scopes and verifies structured menus for valid and empty responses. Mixed-validity and all-invalid responses must return errors with diagnostics and no structured result.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to dee33

The dependency update and recommendation-search tests have no identified issue that needs resolution before merge.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: rejecting incomplete AWS recommendation menus during search.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

• Commit to this branch
• Create a new PR

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

---

_{Comment @coderabbitai help to get the list of available commands.}