Skip to content

ci: lint and vet both platform modules - #457

Merged
cristim merged 2 commits into
mainfrom
fix/lint-vet-all-modules
Sep 30, 2026
Merged

cristim merged 2 commits into
mainfrom
fix/lint-vet-all-modules

Conversation

@cristim

@cristim cristim commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

CI's dedicated lint and vet checks currently skip the separate tests/e2e module. Run both checks for . and tests/e2e, enabling its required e2e tag and reporting failures after checking both modules. Preserve the pinned lint installer, configuration validation, and cache path.

Closes #346.

Validation on macOS with Go 1.26.6 and golangci-lint 2.10.1 built with Go 1.26.6:

  • Actual YAML commands pass for both modules. Root build and tagged e2e compile-only check pass.
  • Real tagged e2e printf and misspell defects pass the original root-only commands and fail the revised vet/lint commands respectively. Both clean checks pass again after removing the fixtures.
  • Eight independent shell probes verify module failures, configuration validation failures, exact tags, cache settings, and continued checks after a root failure.
  • All normal commit hooks pass, including pinned actionlint/zizmor and security scans.
  • Additive merge commit 45a1f0500512bb4dc45ae41e931af00b5ccd724a integrates main ac96148bf0c1ef8630aa16dc1d483b1092b69f7e. Fresh actual-YAML lint/vet, build, failure probes, and normal workflow hooks pass on the integrated tree.
  • Independent adversarial review approved exact commit 45a1f0500512bb4dc45ae41e931af00b5ccd724a after reviewing the full diff and verification evidence. Reviewer: gpt-6-astra, explicitly authorized substitute for the unavailable project-pinned model.

Local act did not execute the job: the sandbox attempt failed on network lookup, and the Docker-enabled retry stalled pulling its runner image. The retry was stopped to release the shared build lock. Hosted Linux CI remains required. Static-analysis probes do not claim running HTTP e2e tests.

Run the existing checks for root and the tagged e2e module, preserving
configuration validation, cache integration, and failures from each module.

Closes #346
@cristim cristim added urgency/this-sprint Within the current sprint type/chore Maintenance / non-user-visible triaged Item has been triaged priority/p1 Next up; this sprint severity/high Significant harm impact/all-users Affects every user effort/m Days labels Sep 30, 2026
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 39 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 70 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: LeanerCloud/cloud-commitments-platform/.coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 75e16aa7-507a-49bb-a5d9-d2fd9426b7c8

📥 Commits

Reviewing files that changed from the base of the PR and between ac96148 and 45a1f05.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml

Comment @coderabbitai help to get the list of available commands.

Integrate the reviewed config and authentication changes without rewriting
the published module coverage commit.
@cristim
cristim merged commit 82b251c into main Sep 30, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/m Days impact/all-users Affects every user priority/p1 Next up; this sprint severity/high Significant harm triaged Item has been triaged type/chore Maintenance / non-user-visible urgency/this-sprint Within the current sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: go vet/lint only cover root module, silently skip tests/e2e [platform part]

1 participant