ci: lint and vet both platform modules - #457
Merged
Merged
Conversation
Run the existing checks for root and the tagged e2e module, preserving configuration validation, cache integration, and failures from each module. Closes #346
Contributor
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 39 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 70 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configurationConfiguration used: Repository: LeanerCloud/cloud-commitments-platform/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (1)
Comment |
Integrate the reviewed config and authentication changes without rewriting the published module coverage commit.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's dedicated lint and vet checks currently skip the separate
tests/e2emodule. Run both checks for.andtests/e2e, enabling its requirede2etag and reporting failures after checking both modules. Preserve the pinned lint installer, configuration validation, and cache path.Closes #346.
Validation on macOS with Go 1.26.6 and golangci-lint 2.10.1 built with Go 1.26.6:
45a1f0500512bb4dc45ae41e931af00b5ccd724aintegrates mainac96148bf0c1ef8630aa16dc1d483b1092b69f7e. Fresh actual-YAML lint/vet, build, failure probes, and normal workflow hooks pass on the integrated tree.45a1f0500512bb4dc45ae41e931af00b5ccd724aafter reviewing the full diff and verification evidence. Reviewer: gpt-6-astra, explicitly authorized substitute for the unavailable project-pinned model.Local
actdid not execute the job: the sandbox attempt failed on network lookup, and the Docker-enabled retry stalled pulling its runner image. The retry was stopped to release the shared build lock. Hosted Linux CI remains required. Static-analysis probes do not claim running HTTP e2e tests.