Conversation
Clone the form before populating its controls so editing retains the provider, approval mode and cadence in the submitted configuration. Cover the Edit and submit path in Jest and the production browser, including repeated opens, defaults, Cancel/Close and mobile behavior.
cristim
added
severity/medium
Contributor
|
Warning Review limit reached
This review includes 3 billable files and costs up to $0.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 24 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 74 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configurationConfiguration used: Repository: LeanerCloud/cloud-commitments-platform/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (3)
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening an existing ladder editor populated its fields and then replaced the form with a clone. The clone reset the provider, approval mode and cadence selects, so saving could submit different values from the selected configuration. Form cloning and listener wiring now happen before population, preserving all existing controls and defaults.
Closes #246.
Independent adversarial
gpt-6-astrareview approved exact commit10d516e93ef9fecfc9bfdb1630d57c144068597bwith no actionable findings, under the owner's authorized local-review alternative. The reviewer reread the complete three-file committed diff and verified committed ladder source against the production bundle's embedded source map.Independent checks passed 10 focused Jest tests and fresh production-browser desktop and phone scenarios. They exercise the real Edit, Save, reopen, Cancel, Close and Add flows, preserved selections and locked edit keys, exact outgoing PUT payloads, changed coverage, reset defaults, alternate providers, navigation and error observation. Both the original source and independently rerun old-order mutation reproduced the select reset. Final source, bundle and committed-SHA checks matched; typecheck, lint, production build and normal commit hooks passed.
Browser evidence uses synthetic HTTP responses at the API boundary and the actual production frontend. It proves visible state and submitted payloads, not live cloud or PostgreSQL persistence. The current backend rejects an account/provider mismatch, so this PR does not claim that the historical Azure example always creates a wrong AWS database row. AWS approval-mode and cadence corruption still reproduced. No purchase, cloud operation or deployment was used for verification.