Skip to content

fix(frontend): remove unsupported purchase cancellation assurance - #466

Open
cristim wants to merge 1 commit into
mainfrom
fix/provider-cancellation-warning
Open

cristim wants to merge 1 commit into
mainfrom
fix/provider-cancellation-warning

Conversation

@cristim

@cristim cristim commented Oct 1, 2026

Copy link
Copy Markdown
Member

The purchase modal's Execute Now warning promised AWS-style cancellation regardless of the selected provider or product. That reassurance was also inaccurate as a general AWS guarantee. The warning now preserves the immediate upfront charge and approval-bypass disclosure while removing only the unsupported cancellation sentence.

Closes #251.

Independent adversarial gpt-6-astra review approved exact commit 9d7ad04f59275395cfa5ec290677fb0ff4638121 with no actionable findings, under the owner's authorized local-review alternative. The reviewer checked the complete three-file committed diff, provider documentation, committed source and the matching freshly built production artifact.

Fresh independent post-commit checks passed 118 Jest tests and four production-browser scenarios. They exercise the actual modal for AWS, Azure and GCP, exact upfront amounts, include-checkbox totals, approval and reopen behavior, mixed-provider fan-out and phone readability. No execute POSTs were emitted. Independent original-source browser tests and an old-sentence mutation failed specifically on the visible warning after the modal, selected recommendation, amount and mode controls passed. Author checks also passed the existing recommendations browser smoke tests, typecheck, lint, build and normal commit hooks.

The production change is one text line. Browser and provider inputs are synthetic HTTP fixtures at the boundary, exercising the real production frontend without a purchase or live cloud call. The correction makes no new cancellation or refund promise. No permission or execution behavior changes.

@cristim cristim added severity/medium Moderate harm urgency/this-sprint Within the current sprint triaged Item has been triaged priority/p1 Next up; this sprint impact/many Affects most users effort/xs Trivial / one-liner type/bug Defect labels Oct 1, 2026
@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 3 billable files and costs up to $0.75.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 22 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 74 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Repository: LeanerCloud/cloud-commitments-platform/.coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 2902dc18-b212-4436-b874-4b4ebee2af40

📥 Commits

Reviewing files that changed from the base of the PR and between 6d9a70f and 9d7ad04.

📒 Files selected for processing (3)
  • frontend/src/__tests__/purchase-modal-submit.test.ts
  • frontend/src/recommendations.ts
  • frontend/tests-e2e/execute-now-warning.spec.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

effort/xs Trivial / one-liner impact/many Affects most users priority/p1 Next up; this sprint severity/medium Moderate harm triaged Item has been triaged type/bug Defect urgency/this-sprint Within the current sprint

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(frontend): Execute Now warning claims AWS-style 24h cancellation for Azure and GCP

1 participant