Conversation
Show the raw quote and submitted targets before irreversible execution. Disclose the stored approval amount as a previous quote, since approval executes a fresh quote under the existing spending limits. Discard late quotes after target edits and keep old modal callbacks from closing a new session. Refresh inventory and history after execution even when its modal has closed. Verify both confirmation failures against the original production bundle, all dismissal paths and precise payloads in Chromium, and quote/session guards by removing them and observing the expected browser failures.
cristim
added
severity/medium
Contributor
|
Warning Review limit reached
This review includes 3 billable files and costs up to $0.75.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 5 minutes for your next included review. View limit detailsLimit details: You’ve used the included review currently available. Your 75 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Review configuration: ⚙️ Run configurationConfiguration used: Repository: LeanerCloud/cloud-commitments-platform/.coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: 📒 Files selected for processing (3)
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RI exchange Execute previously submitted an irreversible exchange without confirmation. Approve omitted the payment and the fact that execution uses a fresh quote.
Confirm the exact raw payment, currency, source RIs, region and submitted targets before Execute. Approval discloses the previous ledger quote and existing spending limits. Reject stale quotes after target edits, keep old modal callbacks from closing a new session, and refresh inventory/history after success even when the originating modal has closed.
Closes #250
Independent Astra review approved exact commit a513872 with no actionable findings. Fresh independent production-browser verification passed all 22 cases with committed-source and production source-map parity. Full Jest verification passed 3,000 tests across 92 suites, with one existing skip; pinned lint, type checking, build and normal commit hooks passed. Parent-code and three guard-removal probes fail their intended assertions, then restored code passes.
Tests use synthetic HTTP responses and make no cloud purchases. Existing backend currency enforcement and currencyless ledger limitations remain tracked by Go #42; this frontend change preserves raw quote currency and does not claim to resolve that issue.